windows adaptation for 1 test

Author: Евгений Блинов

suby/proxy_module.py

@@ -50,19 +50,28 @@ def __call__(
 
         logger.info(f'The beginning of the execution of the command "{arguments_string_representation}".')
 
-        with Popen(list(converted_arguments), stdout=PIPE, stderr=PIPE, bufsize=1, universal_newlines=True) as process:
-            stderr_reading_thread = self.run_stderr_thread(process, stderr_buffer, result, catch_output, stderr_callback)
-            if not isinstance(token, DefaultToken):
-                killing_thread = self.run_killing_thread(process, token, result)
-
-            for line in process.stdout:  # type: ignore[union-attr]
-                stdout_buffer.append(line)
-                if not catch_output:
-                    stdout_callback(line)
-
-            stderr_reading_thread.join()
-            if not isinstance(token, DefaultToken):
-                killing_thread.join()
+        try:
+            with Popen(list(converted_arguments), stdout=PIPE, stderr=PIPE, bufsize=1, universal_newlines=True) as process:
+                stderr_reading_thread = self.run_stderr_thread(process, stderr_buffer, result, catch_output, stderr_callback)
+                if not isinstance(token, DefaultToken):
+                    killing_thread = self.run_killing_thread(process, token, result)
+
+                for line in process.stdout:  # type: ignore[union-attr]
+                    stdout_buffer.append(line)
+                    if not catch_output:
+                        stdout_callback(line)
+
+                stderr_reading_thread.join()
+                if not isinstance(token, DefaultToken):
+                    killing_thread.join()
+
+        except FileNotFoundError as e:
+            if not catch_exceptions:
+                message = f'Error when executing the command "{arguments_string_representation}".'
+                logger.error(message)
+                raise RunningCommandError(message, result) from e
+            return result
+
 
         self.fill_result(stdout_buffer, stderr_buffer, process.returncode, result)
 

tests/units/test_proxy_module.py

@@ -523,6 +523,7 @@ def test_multiple_args_without_split(command):
     assert result.returncode == 0
 
 
+@pytest.mark.skipif(platform.system() == 'Windows', reason='On windows the split mode is default')
 @pytest.mark.parametrize(
     ['command', 'exception_message'],
     [
@@ -536,6 +537,20 @@ def test_wrong_command(command, exception_message):
         suby(*command)
 
 
+@pytest.mark.skipif(platform.system() != 'Windows', reason='On windows the split mode is default')
+@pytest.mark.parametrize(
+    ['command', 'exception_message'],
+    [
+        ((Path(sys.executable), '-c "'), 'The expression "-c "" cannot be parsed.'),
+        ((sys.executable, '-c "'), 'The expression "-c "" cannot be parsed.'),
+        (('python -c "',), 'The expression "python -c "" cannot be parsed.'),
+    ]
+)
+def test_wrong_command_windows(command, exception_message):
+    with pytest.raises(WrongCommandError, match=full_match(exception_message)):
+        suby(*command)
+
+
 @pytest.mark.skipif(platform.system() == 'Windows', reason='On windows the split mode is default')
 def test_envs_for_subprocess_are_same_as_parent():
     subprocess_env = json.loads(suby('python -c "import os, json; print(json.dumps(dict(os.environ)))"').stdout)