Skip to content

Re-verify gold-set rows labeled from LFS-tracked files #38

Description

@khatchad

Fallout from #34. Before the fix in #37, inspect_commit.py --download could print file changes and then report "no column change" on an LFS-tracked file whose columns it never read. git lfs pull exits 0 when it fetches nothing, so there was no crash, no warning, and no way for the person labeling to tell "this commit changed no columns" apart from "we could not read either side."

Any row in tests/gold_set.csv whose label was informed by that output could be wrong, specifically in the direction of a false negative: a real add column(s), delete column(s), or rename column(s) recorded as something weaker, or as not-a-refactoring.

This is not hypothetical for the corpus. TheoTsio/Health_Misinfo tracks test/train/val.csv under LFS, and it is in the gold set.

What Needs Doing

  1. Identify which gold-set commits touch LFS-tracked files. Nothing in gold_set.csv records this (it has only DatasetID, CommitId, label, verified_by, notes), so it has to be recovered by re-running the inspection.
  2. Re-inspect those commits with the fixed --download from Fix --download silently misreporting LFS-tracked files #37 and confirm the label.
  3. Where a label was reached by other means (reading the diff on the Hub, a manual download), note that in notes so the provenance is recoverable next time.
  4. Add the saraprice/OpenHermes-FN-headlines-SA-ihateyou rows. They exist in the annotation source but not in the committed CSV: the 2026-07-21 export left them out because the rows could not be verified until the Xet fetch fix landed. The flagged column-reorder row is adjudicated as restructure/reorg/consolidate and that label stands, so these need finalizing rather than re-judging.
  5. Land the corrected labels in tests/gold_set.csv and push. This issue is not done until the committed file reflects the re-verification; a corrected label that has not reached main is not a corrected label as far as the classifier, its evaluation, or the second rater are concerned.

Why It Matters Beyond The Gold Set

The gold set is the development oracle for the classifier (#11) and the basis for its evaluation. A systematic false-negative bias in the oracle would show up as the classifier looking worse than it is on exactly the column-change types, and would quietly corrupt the per-type precision/recall numbers.

Worth doing before the classifier is scored, not after.

Sequencing

Unblocked as of 2026-07-21. This needed fixes to two separate LFS read paths, both now on main: #37 for --download under classic LFS, and #44 (PR #45) for Xet-backed repositories. Pull main before starting.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions