Rename methods for clarification.

Rename methods to clarify that they return the value number for the argument, not the argument itself.

Author: khatchad

com.ibm.wala.cast.python.ml/source/com/ibm/wala/cast/python/ml/client/Constant.java

@@ -33,18 +33,18 @@ public Constant(PointsToSetVariable source, CGNode node) {
   protected Set<List<Dimension<?>>> getDefaultShapes(PropagationCallGraphBuilder builder) {
     // If the shape argument is not specified, then the shape is inferred from the shape of value.
     // TODO: Handle keyword arguments.
-    return getShapes(builder, this.getValueNumberForValueArgument());
+    return getShapes(builder, this.getValueArgumentValueNumber());
   }
 
   @Override
   protected EnumSet<DType> getDefaultDTypes(PropagationCallGraphBuilder builder) {
     // If the dtype argument is not specified, then the type is inferred from the type of value.
     // TODO: Handle keyword arguments.
-    return getDTypes(builder, this.getValueNumberForValueArgument());
+    return getDTypes(builder, this.getValueArgumentValueNumber());
   }
 
-  protected int getValueNumberForValueArgument() {
-    return getValueNumberForArgument(this.getValueParameterPosition());
+  protected int getValueArgumentValueNumber() {
+    return getArgumentValueNumber(this.getValueParameterPosition());
   }
 
   protected int getValueParameterPosition() {

com.ibm.wala.cast.python.ml/source/com/ibm/wala/cast/python/ml/client/Fill.java

@@ -32,7 +32,7 @@ public Fill(PointsToSetVariable source, CGNode node) {
   }
 
   @Override
-  protected int getValueNumberForDTypeArgument() {
+  protected int getDTypeArgumentValueNumber() {
     return VALUE_NUMBER_FOR_DTYPE_ARGUMENT;
   }
 

com.ibm.wala.cast.python.ml/source/com/ibm/wala/cast/python/ml/client/TensorGenerator.java

@@ -218,8 +218,8 @@ protected Set<List<Dimension<?>>> getShapesFromShapeArgument(
    * @return The value number for the shape argument in the function call. May return a number less
    *     than or equal to 0 if there is no shape parameter.
    */
-  protected int getValueNumberForShapeArgument() {
-    return this.getValueNumberForArgument(this.getShapeParameterPosition());
+  protected int getShapeArgumentValueNumber() {
+    return this.getArgumentValueNumber(this.getShapeParameterPosition());
   }
 
   protected abstract int getShapeParameterPosition();
@@ -235,7 +235,7 @@ protected Set<List<Dimension<?>>> getShapes(PropagationCallGraphBuilder builder)
 
     // Get the shape from the explicit argument.
     // FIXME: Handle keyword arguments.
-    int shapeArgValueNum = this.getValueNumberForShapeArgument();
+    int shapeArgValueNum = this.getShapeArgumentValueNumber();
     OrdinalSet<InstanceKey> pointsToSet = null;
 
     if (shapeArgValueNum > 0) {
@@ -456,16 +456,16 @@ protected EnumSet<DType> getDTypesFromDTypeArgument(
    * @return The value number for the dtype argument in the function call or -1 if the dtype
    *     argument is not supported.
    */
-  protected int getValueNumberForDTypeArgument() {
-    return this.getValueNumberForArgument(this.getDTypeParameterPosition());
+  protected int getDTypeArgumentValueNumber() {
+    return this.getArgumentValueNumber(this.getDTypeParameterPosition());
   }
 
   protected abstract int getDTypeParameterPosition();
 
   protected EnumSet<DType> getDTypes(PropagationCallGraphBuilder builder) {
     PointerAnalysis<InstanceKey> pointerAnalysis = builder.getPointerAnalysis();
 
-    int valNum = this.getValueNumberForDTypeArgument();
+    int valNum = this.getDTypeArgumentValueNumber();
     OrdinalSet<InstanceKey> pointsToSet = null;
 
     if (valNum > 0) {
@@ -610,7 +610,7 @@ public String toString() {
    */
   protected abstract String getSignature();
 
-  protected int getValueNumberForArgument(int parameterPosition) {
+  protected int getArgumentValueNumber(int parameterPosition) {
     if (parameterPosition < 0) return -1; // No such argument.
 
     return this.getNode().getMethod().isStatic()

com.ibm.wala.cast.python.ml/source/com/ibm/wala/cast/python/ml/client/ZerosLike.java

@@ -25,7 +25,7 @@ public ZerosLike(PointsToSetVariable source, CGNode node) {
   }
 
   @Override
-  protected int getValueNumberForShapeArgument() {
+  protected int getShapeArgumentValueNumber() {
     return VALUE_NUMBER_FOR_SHAPE_ARGUMENT;
   }