Skip to content

Commit b0414b5

Browse files
committed
Make the code a little more readable.
It was a bit dense. Also, extract local variable.
1 parent aa3fbea commit b0414b5

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

com.ibm.wala.cast.python.ml/source/com/ibm/wala/cast/python/ml/client/PythonTensorAnalysisEngine.java

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -663,29 +663,32 @@ public TensorTypeAnalysis performAnalysis(PropagationCallGraphBuilder builder)
663663

664664
TensorType mnistData = TensorType.mnistInput();
665665
Map<PointsToSetVariable, TensorType> init = HashMapFactory.make();
666-
for (PointsToSetVariable v : sources) {
667-
init.put(v, mnistData);
668-
}
666+
667+
for (PointsToSetVariable v : sources) init.put(v, mnistData);
669668

670669
Map<PointsToSetVariable, TensorType> placeholders =
671670
handleShapeSourceOp(builder, dataflow, placeholder, 2);
672671
logger.fine(() -> "Placeholders: " + placeholders);
673-
for (Map.Entry<PointsToSetVariable, TensorType> e : placeholders.entrySet()) {
672+
673+
for (Map.Entry<PointsToSetVariable, TensorType> e : placeholders.entrySet())
674674
init.put(e.getKey(), e.getValue());
675-
}
676675

677676
Map<PointsToSetVariable, TensorType> setCalls = HashMapFactory.make();
678677
Map<PointsToSetVariable, TensorType> set_shapes = getShapeSourceCalls(set_shape, builder, 1);
678+
679679
for (Map.Entry<PointsToSetVariable, TensorType> x : set_shapes.entrySet()) {
680-
CGNode setNode = ((LocalPointerKey) x.getKey().getPointerKey()).getNode();
681-
int defVn = ((LocalPointerKey) x.getKey().getPointerKey()).getValueNumber();
680+
LocalPointerKey localPointerKey = (LocalPointerKey) x.getKey().getPointerKey();
681+
CGNode setNode = localPointerKey.getNode();
682+
int defVn = localPointerKey.getValueNumber();
682683
SSAInstruction read = setNode.getDU().getDef(defVn);
683684
SSAInstruction call = setNode.getDU().getDef(read.getUse(0));
685+
684686
PointerKey setKey =
685687
builder
686688
.getPointerAnalysis()
687689
.getHeapModel()
688690
.getPointerKeyForLocal(setNode, call.getUse(0));
691+
689692
setCalls.put(builder.getPropagationSystem().findOrCreatePointsToSet(setKey), x.getValue());
690693
}
691694

0 commit comments

Comments
 (0)