Skip to content

APNs4r::Sender can enter infinite loop. Yikes! #1

@noahmiller

Description

@noahmiller

In APNs4r::Sender#push, if @ssl.write fails there are two bugs in the rescue block:

  1. The ssl connection is not recreated, since @ssl ||= connect is used rather than @ssl = connect.
  2. If the write fails again (e.g. because ssl has disconnected, but isn't nil), retry will be call an infinite number of times.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions