Update toolchain (#81)

* Update to latest nightly rust.
  It fixes problems with incremental builds announced in Rust 1.51. See https://blog.rust-lang.org/2021/05/10/Rust-1.52.1.html

* Add stdlib dirs to gitignore

* Fix BTreeMap import in parachain-staking

* Fix clippy warnings

* Fix clippy warnings

* Remove unused attribute

* Remove RUSTFLAGS=-D warnings form CI config

* Disable check-benchmarks make target (temporary)

Author: vitvakatu

.github/workflows/tests.yml

@@ -10,7 +10,6 @@ env:
   CARGO_INCREMENTAL: 1
   CARGO_NET_RETRY: 10
   CARGO_TERM_COLOR: always
-  RUSTFLAGS: -D warnings
 
 jobs:
   test:

.gitignore

@@ -18,5 +18,7 @@
 
 artifacts/
 /node/move/stdlib/
+/pallets/sp-mvm/tests/assets/stdlib/
+/pallets/sp-mvm/tests/benchmark_assets/stdlib/
 
 .direnv

Cargo.lock

@@ -10,7 +10,7 @@ check:
 	cargo check --all
 	cargo check --all --tests
 	make check-no-std
-	make check-benchmarks
+	#make check-benchmarks
 
 .PHONY: check-benchmarks
 check-benchmarks:

Makefile

@@ -74,7 +74,9 @@ pub mod pallet {
         traits::{AtLeast32BitUnsigned, Saturating, Zero},
         Perbill, Percent, RuntimeDebug,
     };
-    use sp_std::{cmp::Ordering, collections::btree_map::BTreeMap, prelude::*};
+    use sp_std::{cmp::Ordering, prelude::*};
+    #[cfg(feature = "std")]
+    use sp_std::collections::btree_map::BTreeMap;
 
     /// Pallet for parachain staking
     #[pallet::pallet]
@@ -1114,12 +1116,12 @@ pub mod pallet {
                     T::Currency::free_balance(&nominator) >= balance,
                     "Account does not have enough balance to place nomination."
                 );
-                let cn_count = if let Some(x) = col_nominator_count.get(&target) {
+                let cn_count = if let Some(x) = col_nominator_count.get(target) {
                     *x
                 } else {
                     0u32
                 };
-                let nn_count = if let Some(x) = nom_nominator_count.get(&nominator) {
+                let nn_count = if let Some(x) = nom_nominator_count.get(nominator) {
                     *x
                 } else {
                     0u32
@@ -1133,12 +1135,12 @@ pub mod pallet {
                 ) {
                     log::warn!("Join nominators failed in genesis with error {:?}", error);
                 } else {
-                    if let Some(x) = col_nominator_count.get_mut(&target) {
+                    if let Some(x) = col_nominator_count.get_mut(target) {
                         *x += 1u32;
                     } else {
                         col_nominator_count.insert(target.clone(), 1u32);
                     };
-                    if let Some(x) = nom_nominator_count.get_mut(&nominator) {
+                    if let Some(x) = nom_nominator_count.get_mut(nominator) {
                         *x += 1u32;
                     } else {
                         nom_nominator_count.insert(nominator.clone(), 1u32);

pallets/parachain-staking/src/lib.rs

@@ -83,7 +83,7 @@ where
             address,
             ticker
         );
-        address_to_account::<T::AccountId>(&address)
+        address_to_account::<T::AccountId>(address)
             .map_err(|_| error!("Can't convert address from Move to Substrate."))
             .and_then(|address| {
                 <balances::Pallet<T> as Currency<T::AccountId>>::free_balance(&address)
@@ -106,7 +106,7 @@ where
         }
 
         trace!("withdraw resource {} requested, amount: {}", ticker, amount);
-        let imbalance = address_to_account::<T::AccountId>(&address)
+        let imbalance = address_to_account::<T::AccountId>(address)
             .map_err(|_err| error!("Can't convert address from Move to Substrate."))
             .and_then(|address| {
                 amount
@@ -137,7 +137,7 @@ where
         }
 
         trace!("deposit resource {} requested, amount: {}", ticker, amount);
-        let imbalance = address_to_account::<T::AccountId>(&address)
+        let imbalance = address_to_account::<T::AccountId>(address)
             .map_err(|_| error!("Can't convert address from Move to Substrate."))
             .and_then(|address| {
                 amount

pallets/sp-mvm/src/balance.rs

@@ -19,7 +19,7 @@ impl<AccountId: DecodeT> TryFrom<InternalModuleId> for MoveModuleId<AccountId> {
 
     fn try_from(id: InternalModuleId) -> Result<Self, Self::Error> {
         Ok(Self {
-            owner: address_to_account::<AccountId>(&id.address())?,
+            owner: address_to_account::<AccountId>(id.address())?,
             module: id.name().as_bytes().to_vec(),
         })
     }

pallets/sp-mvm/src/types.rs

@@ -1,5 +1,3 @@
-#![cfg_attr(not(feature = "std"), no_std)]
-
 use sp_runtime::{generic, MultiSignature};
 use sp_runtime::traits::{Verify, IdentifyAccount};
 

runtime/src/primitives.rs

@@ -1 +1 @@
-nightly-2021-04-24
+nightly-2021-07-26