Skip to content
This repository was archived by the owner on May 13, 2020. It is now read-only.
This repository was archived by the owner on May 13, 2020. It is now read-only.

running stable more than once can result in merge conflicts which results in bad deps #58

@aturley

Description

@aturley

Summary

If one of your dependencies points to a git tag/commit rather than master then running stable a second time can result in merge conflicts which can then cause the checkout of the branch to fail, leaving the .deps folder in a bad state.

Steps to Reproduce

  1. Create a bundle.json file that uses a tag as the version. I'm using this:
{
"deps": [
  {
    "type": "local",
    "local-path": "../../lib"
  },
  {
    "type": "local",
    "local-path": "lib"
  },
  {
    "type": "local",
    "local-path": "../../go_api/pony"
  },
  {
    "type": "github",
    "repo": "WallarooLabs/pony-kafka",
    "tag": "ee70576"
  }
]
}
  1. Run stable fetch twice.

Expected Behavior

Stable fetches the correct version of the library (pony-kafka in the case of the example above).

Actual Behavior

There is a merge conflict when pulling in the repo and so the git checkout command fails, leaving the .deps directory in a bad state.

Notes

I talked to @SeanTAllen and @jemc about it and we think the right thing to do for now is to call git -C [root] fetch instead of git -C [root] pull [url] (here)[https://github.com/ponylang/pony-stable/blob/master/stable/dep.pony#L54]. There's probably a more efficient way to do this in the future, but for now that's probably the best solution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions