Fix failure to build pony tools with Homebrew

Self-hosted tools like pony-lint, pony-lsp, and pony-doc pull in
`use "lib:z"` via pony_compiler. When zlib lives outside the default
system linker search paths (e.g. Homebrew), embedded LLD cannot resolve
`-lz` while building those tools. Pass the resolved zlib library
directory through the self-hosted ponyc invocations so those builds can
find libz.

Author: SeanTAllen

.release-notes/fix-zlib-selfhosted-tools.md

@@ -0,0 +1,3 @@
+## Fix failure to build pony tools with Homebrew
+
+When building ponyc from source with Homebrew, the self-hosted tools (pony-lint, pony-lsp, pony-doc) failed to link because the embedded LLD linker couldn't find zlib. Homebrew installs zlib outside the default system linker search paths, and while CMake resolved the correct location for linking ponyc itself, that path wasn't forwarded to the ponyc invocations that compile the tools.

CMakeLists.txt

@@ -224,10 +224,21 @@ if(NOT PONY_CROSS_LIBPONYRT)
     # message("PONYC_LLVM_LIBS: ${PONYC_LLVM_LIBS}")
 
     set(PONYC_LLD_LIBS lldELF lldMachO lldCOFF lldWasm lldMinGW lldCommon)
+    set(PONYC_SELFHOSTED_TOOL_PATH_ARGS "")
 
     if(NOT MSVC)
         find_package(ZLIB REQUIRED)
         set(PONYC_EXTRA_LIBS ZLIB::ZLIB)
+
+        # Self-hosted Pony tools use `use "lib:z"` via pony_compiler. Pass the
+        # resolved zlib libdir so embedded LLD can find non-system installs.
+        foreach(PONYC_ZLIB_LIBRARY IN LISTS ZLIB_LIBRARIES)
+            if(IS_ABSOLUTE "${PONYC_ZLIB_LIBRARY}")
+                get_filename_component(PONYC_ZLIB_LIBRARY_DIR "${PONYC_ZLIB_LIBRARY}" DIRECTORY)
+                list(APPEND PONYC_SELFHOSTED_TOOL_PATH_ARGS "--path" "${PONYC_ZLIB_LIBRARY_DIR}")
+                break()
+            endif()
+        endforeach()
     endif()
 endif()
 

tools/pony-doc/CMakeLists.txt

@@ -16,8 +16,9 @@ add_dependencies(tools.pony-doc libponyc-standalone)
 
 file(GLOB_RECURSE DOC_SOURCES CONFIGURE_DEPENDS "*.pony")
 add_custom_command(OUTPUT ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/${PONY_DOC_EXECUTABLE}
+  COMMAND_EXPAND_LISTS
   COMMAND echo "Building pony-doc..."
-  COMMAND $<TARGET_FILE:ponyc> ${PONY_CPU_FLAG} --path ${CMAKE_CURRENT_SOURCE_DIR} --path ${CMAKE_CURRENT_SOURCE_DIR}/../lib/ponylang/pony_compiler/ -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} ${CMAKE_CURRENT_SOURCE_DIR}
+  COMMAND $<TARGET_FILE:ponyc> ${PONY_CPU_FLAG} --path ${CMAKE_CURRENT_SOURCE_DIR} --path ${CMAKE_CURRENT_SOURCE_DIR}/../lib/ponylang/pony_compiler/ ${PONYC_SELFHOSTED_TOOL_PATH_ARGS} -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} ${CMAKE_CURRENT_SOURCE_DIR}
   DEPENDS
     ${DOC_SOURCES}
     $<TARGET_FILE:ponyc>
@@ -31,8 +32,9 @@ set(PONY_DOC_TEST_EXECUTABLE "pony-doc-tests${CMAKE_EXECUTABLE_SUFFIX}")
 add_custom_target(tools.pony-doc-tests DEPENDS ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/${PONY_DOC_TEST_EXECUTABLE})
 
 add_custom_command(OUTPUT ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/${PONY_DOC_TEST_EXECUTABLE}
+  COMMAND_EXPAND_LISTS
   COMMAND echo "Building pony-doc-tests..."
-  COMMAND $<TARGET_FILE:ponyc> --path ${CMAKE_CURRENT_SOURCE_DIR} --path ${CMAKE_CURRENT_SOURCE_DIR}/../lib/ponylang/pony_compiler/ -b ${PONY_DOC_TEST_EXECUTABLE} -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} ${CMAKE_CURRENT_SOURCE_DIR}/test
+  COMMAND $<TARGET_FILE:ponyc> --path ${CMAKE_CURRENT_SOURCE_DIR} --path ${CMAKE_CURRENT_SOURCE_DIR}/../lib/ponylang/pony_compiler/ ${PONYC_SELFHOSTED_TOOL_PATH_ARGS} -b ${PONY_DOC_TEST_EXECUTABLE} -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} ${CMAKE_CURRENT_SOURCE_DIR}/test
   DEPENDS
     ${DOC_SOURCES}
     $<TARGET_FILE:ponyc>

tools/pony-lint/CMakeLists.txt

@@ -16,8 +16,9 @@ add_dependencies(tools.pony-lint libponyc-standalone)
 
 file(GLOB_RECURSE LINT_SOURCES CONFIGURE_DEPENDS "*.pony")
 add_custom_command(OUTPUT ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/${PONY_LINT_EXECUTABLE}
+  COMMAND_EXPAND_LISTS
   COMMAND echo "Building pony-lint..."
-  COMMAND $<TARGET_FILE:ponyc> ${PONY_CPU_FLAG} --path ${CMAKE_CURRENT_SOURCE_DIR} --path ${CMAKE_CURRENT_SOURCE_DIR}/../lib/ponylang/pony_compiler/ -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} ${CMAKE_CURRENT_SOURCE_DIR}
+  COMMAND $<TARGET_FILE:ponyc> ${PONY_CPU_FLAG} --path ${CMAKE_CURRENT_SOURCE_DIR} --path ${CMAKE_CURRENT_SOURCE_DIR}/../lib/ponylang/pony_compiler/ ${PONYC_SELFHOSTED_TOOL_PATH_ARGS} -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} ${CMAKE_CURRENT_SOURCE_DIR}
   DEPENDS
     ${LINT_SOURCES}
     $<TARGET_FILE:ponyc>

tools/pony-lsp/CMakeLists.txt

@@ -17,8 +17,9 @@ add_dependencies(tools.pony-lsp libponyc-standalone)
 # TODO STA: --path entries are temporary until a ponyc bug is fixed.
 file(GLOB_RECURSE LSP_SOURCES CONFIGURE_DEPENDS "*.pony")
 add_custom_command(OUTPUT ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/${PONY_LSP_EXECUTABLE}
+  COMMAND_EXPAND_LISTS
   COMMAND echo "Building pony-lsp..."
-  COMMAND $<TARGET_FILE:ponyc> ${PONY_CPU_FLAG} --path ${CMAKE_CURRENT_SOURCE_DIR} --path ${CMAKE_CURRENT_SOURCE_DIR}/../lib/ponylang/pony_compiler/ -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} ${CMAKE_CURRENT_SOURCE_DIR}
+  COMMAND $<TARGET_FILE:ponyc> ${PONY_CPU_FLAG} --path ${CMAKE_CURRENT_SOURCE_DIR} --path ${CMAKE_CURRENT_SOURCE_DIR}/../lib/ponylang/pony_compiler/ ${PONYC_SELFHOSTED_TOOL_PATH_ARGS} -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} ${CMAKE_CURRENT_SOURCE_DIR}
   DEPENDS
     ${LSP_SOURCES}
     $<TARGET_FILE:ponyc>