Require pony-lsp 0.61.0+

Remove ponyStdLibPath setting, as this is no longer needed

Author: orien

.release-notes/15.md

@@ -0,0 +1,3 @@
+## Require pony-lsp 0.61.0+
+
+`pony-lsp` 0.61.0 or above is now required. This version automatically locates the Pony standard library, so the `pony.ponyStdLibPath` setting has been removed. If you have this set in your `settings.json`, you can safely remove it.

README.md

@@ -29,14 +29,20 @@ Install `pony-lsp` and [`ponyc`](https://github.com/ponylang/ponyc) and ensure t
 brew install ponyc
 ```
 
+> [!IMPORTANT]
+> `pony-lsp` 0.61.0 or above is required, to ensure it correctly locates the Pony standard library and accepts the needed configuration options.
+
 The extension will show an error if `pony-lsp` is not found.
 
 ### Configuration
 
-**`pony.ponyStdLibPath`**: The file path to the Pony standard library. If set, prepended to `PONYPATH`.
+**`pony.lsp.executable`**: The file path to the `pony-lsp` executable. If not set, the extension will search for `pony-lsp` on your `PATH`.
+
+**`pony.trace.server`**: Traces the communication between VS Code and the Pony language server. Accepted values are `"off"` (default), `"messages"`, and `"verbose"`.
 
 ```json
 {
-  "pony.ponyStdLibPath": "/usr/local/lib/ponyc/0.60.5/packages"
+  "pony.lsp.executable": "/usr/local/bin/pony-lsp",
+  "pony.trace.server": "off"
 }
 ```

package.json

@@ -24,7 +24,7 @@
   "contributes": {
     "configuration": {
       "type": "object",
-      "title": "Pony configuration",
+      "title": "Pony",
       "properties": {
         "pony.trace.server": {
           "scope": "window",
@@ -42,12 +42,6 @@
           "type": "string",
           "default": "",
           "description": "File location of the Pony language server executable. If not set, will search for `pony-lsp` on the PATH."
-        },
-        "pony.ponyStdLibPath": {
-          "scope": "window",
-          "type": "string",
-          "default": "",
-          "description": "Path to the Pony standard library packages directory. If not set, pony-lsp will try to auto-detect it."
         }
       }
     },

src/extension.ts

@@ -58,30 +58,13 @@ export async function activate(_context: ExtensionContext) {
     }
     outputChannel.appendLine(`Using ${lspExecutable} from PATH`);
   }
-  // Set or append to PONYPATH environment variable
-  const ponyStdLibPath = config.get<string>('ponyStdLibPath', '');
-  const env = { ...process.env };
-  if (ponyStdLibPath) {
-    if (env.PONYPATH) {
-      const pathSeparator = process.platform === 'win32' ? ';' : ':';
-      env.PONYPATH = `${ponyStdLibPath}${pathSeparator}${env.PONYPATH}`;
-      outputChannel.appendLine(`Prepending to PONYPATH: ${ponyStdLibPath}`);
-      outputChannel.appendLine(`Full PONYPATH: ${env.PONYPATH}`);
-    } else {
-      env.PONYPATH = ponyStdLibPath;
-      outputChannel.appendLine(`Setting PONYPATH: ${ponyStdLibPath}`);
-    }
-  } else if (env.PONYPATH) {
-    outputChannel.appendLine(`Using existing PONYPATH: ${env.PONYPATH}`);
-  }
-
   // If the extension is launched in debug mode then the debug server options are used
   // Otherwise the run options are used
   let serverOptions: ServerOptions = {
     command: lspExecutable,
     args: ["stdio"],
     transport: TransportKind.stdio,
-    options: { env }
+    options: { env: process.env }
   };
 
   // Options to control the language client