Skip to content

Commit 6d0b2b1

Browse files
committed
fix(sound): improve audio sink/source display names
1 parent 96e90bf commit 6d0b2b1

2 files changed

Lines changed: 20 additions & 4 deletions

File tree

cosmic-settings/src/pages/sound/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ fn input() -> Section<crate::pages::Message> {
355355
.push(horizontal_space().width(8.))
356356
.push(slider);
357357
let devices = widget::dropdown::popup_dropdown(
358-
&page.model.sources.description,
358+
&page.model.sources.display,
359359
Some(page.model.sources.active.unwrap_or(0)),
360360
Message::SetDefaultSource,
361361
window::Id::RESERVED,
@@ -435,7 +435,7 @@ fn output() -> Section<crate::pages::Message> {
435435
.push(slider);
436436

437437
let devices = widget::dropdown::popup_dropdown(
438-
&page.model.sinks.description,
438+
&page.model.sinks.display,
439439
Some(page.model.sinks.active.unwrap_or(0)),
440440
Message::SetDefaultSink,
441441
window::Id::RESERVED,

cosmic-settings/src/pages/sound/model.rs

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,14 @@ impl Model {
183183

184184
None
185185
})
186-
.unwrap_or_else(|| self.sinks.description[pos].clone());
186+
.unwrap_or_else(|| {
187+
[
188+
&node.device_profile_description,
189+
" - ",
190+
&*self.sinks.description[pos],
191+
]
192+
.concat()
193+
});
187194

188195
if let Some(default_node_id) = self.default_sink {
189196
if default_node_id == node_id {
@@ -241,7 +248,16 @@ impl Model {
241248

242249
None
243250
})
244-
.unwrap_or_else(|| Some(self.sources.description[pos].clone()))
251+
.unwrap_or_else(|| {
252+
Some(
253+
[
254+
&node.device_profile_description,
255+
" - ",
256+
&*self.sources.description[pos],
257+
]
258+
.concat(),
259+
)
260+
})
245261
{
246262
self.sources.display[pos] = name;
247263
} else {

0 commit comments

Comments
 (0)