Discovered while testing #330, but also happening on master (c3d9c72).
If I reboot and then immediately attempt to upgrade with pop-upgrade release upgrade -f, the recovery iso download is cancelled and I get an incorrect message telling me to reboot when com.system76.PopUpgrade.Notify triggers a check for pop-upgrade updates.
If I reboot and immediately try to use pop-upgrade recovery upgrade from-release to update the recovery partition, I get an incorrect message stating that the recovery partition is "refueled and ready to go" when it actually has not been updated.
It would be best if upgrades weren't killed by an update check; pop-upgrade checks for available updates to itself before it does anything, so it's not critical for an update check to take place in the middle of an action. If that's not possible, then pop-upgrade should at least not spit out a success message when it's killed, and should instead correctly state that the action was cancelled.
Discovered while testing #330, but also happening on master (c3d9c72).
If I reboot and then immediately attempt to upgrade with
pop-upgrade release upgrade -f, the recovery iso download is cancelled and I get an incorrect message telling me to reboot whencom.system76.PopUpgrade.Notifytriggers a check for pop-upgrade updates.If I reboot and immediately try to use
pop-upgrade recovery upgrade from-releaseto update the recovery partition, I get an incorrect message stating that the recovery partition is "refueled and ready to go" when it actually has not been updated.It would be best if upgrades weren't killed by an update check; pop-upgrade checks for available updates to itself before it does anything, so it's not critical for an update check to take place in the middle of an action. If that's not possible, then pop-upgrade should at least not spit out a success message when it's killed, and should instead correctly state that the action was cancelled.