Skip to content

Commit 22e627b

Browse files
authored
increase verbosity for jira syncer (#19)
1 parent 978fbb8 commit 22e627b

9 files changed

+19
-13
lines changed

config.py

+1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ class Settings(BaseSettings):
4343
filter_rule: Union[FilterRule, str, None] = Field(default=None)
4444
operation_kind: OperationKind = OperationKind.scorecard_reminder
4545
target_kind: TargetKind = TargetKind.slack
46+
log_level: str = "INFO"
4647

4748
class Config:
4849
env_prefix = "INPUT_"

core/base_handler.py

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
from config import settings
44
from port.client import PortClient
55

6-
logging.basicConfig(level=logging.INFO)
76
logger = logging.getLogger(__name__)
87

98

core/github_handler.py

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from generators.github import GithubIssueGenerator
66
from targets.github import Github
77

8-
logging.basicConfig(level=logging.INFO)
98
logger = logging.getLogger(__name__)
109

1110

core/jira_handler.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from generators.jira import JiraIssueGenerator
66
from targets.jira import Jira
77

8-
logging.basicConfig(level=logging.INFO)
98
logger = logging.getLogger(__name__)
109

1110

@@ -86,9 +85,10 @@ def ticket_handler(self):
8685
elif not rule_successful and subtask["fields"]["resolution"]:
8786
Jira().reopen_issue(subtask)
8887
elif not rule_successful:
88+
logger.debug(
89+
f"Creating subtask for {rule.get('title')} in {parent_key} for {entity.get('name')}")
8990
Jira().create_issue(generated_subtask)
9091

9192
if (scorecard_level_completed and
92-
task_exists and
93-
not task["fields"]["resolution"]):
93+
task_exists and not task["fields"]["resolution"]):
9494
Jira().resolve_issue(task)

core/slack_handler.py

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from generators.slack import SlackMessageGenerator
66
from targets.slack import Slack
77

8-
logging.basicConfig(level=logging.INFO)
98
logger = logging.getLogger(__name__)
109

1110

main.py

+14-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from typing import Dict, Type
2+
import logging
23

34
from config import settings
45
from core.base_handler import BaseHandler
@@ -7,11 +8,21 @@
78
from core.slack_handler import SlackHandler
89

910
HANDLERS: Dict[str, Type[BaseHandler]] = {
10-
"jira": JiraHandler,
11-
"slack": SlackHandler,
12-
"github": GithubHandler
11+
"jira": JiraHandler,
12+
"slack": SlackHandler,
13+
"github": GithubHandler
1314
}
1415

16+
if len(logging.getLogger().handlers) > 0:
17+
# The Lambda environment pre-configures a handler logging to stderr.
18+
# If a handler is already configured, `.basicConfig` does not execute.
19+
# Thus we set the level directly.
20+
# https://stackoverflow.com/a/56579088
21+
logging.getLogger().setLevel(settings.log_level)
22+
else:
23+
logging.basicConfig(level=settings.log_level)
24+
logger = logging.getLogger(__name__)
25+
1526
if __name__ == '__main__':
1627
operation_kind = settings.operation_kind
1728
handler = HANDLERS.get(settings.target_kind, SlackHandler)()

targets/github.py

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import requests
66
from config import settings
77

8-
logging.basicConfig(level=logging.INFO)
98
logger = logging.getLogger(__name__)
109

1110
REQUESTS_BACKOFF_FACTOR = 60

targets/jira.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
from config import settings
1010

11-
logging.basicConfig(level=logging.INFO)
1211
logger = logging.getLogger(__name__)
1312

1413

@@ -30,7 +29,7 @@ def __init__(self) -> None:
3029

3130
def create_issue(self, params: dict[str, Any]) -> dict[str, Any]:
3231
logger.info(f"Creating new issue: {params['fields']['summary']}")
33-
32+
logger.debug(f"Creating new issue with params: {params}")
3433
create_issue_response = requests.request(
3534
"POST", f"{self.api_url}/issue", json=params, headers=self.headers
3635
)

targets/slack.py

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
from config import settings
77

8-
logging.basicConfig(level=logging.INFO)
98
logger = logging.getLogger(__name__)
109

1110

0 commit comments

Comments
 (0)