Merge pull request #33 from port-labs/fixes-to-github-issues-sync

matarpeles · web-flow · commit d7205e9bfe25 · 2024-12-15T09:53:59.000+02:00
Fix - Scorecard label for GitHub issue sync to be set from the scorecard identifier
diff --git a/generators/github.py b/generators/github.py
@@ -22,7 +22,7 @@ def generate_issue(
             f"\n> :bulb: **Tip:** Scorecards are a way for you and your team to define and track standards, metrics, and KPIs in different categories such as production readiness, quality, productivity, and more. For more information about your scorecards, go to [Port]({get_port_url(settings.port_region)})"
             "\n# Sub-Tasks"
             "\n" + "\n".join(tasks) + "\n",
-            "labels": ["Port", scorecard_title, level, blueprint, entity["identifier"]],
+            "labels": ["Port", scorecard.get("identifier",""), level, blueprint, entity["identifier"]],
         }
 
     def generate_task(self, rule: dict[str, Any]):

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ def generate_issue(`
`22`	`22`	`f"\n> :bulb: Tip: Scorecards are a way for you and your team to define and track standards, metrics, and KPIs in different categories such as production readiness, quality, productivity, and more. For more information about your scorecards, go to [Port]({get_port_url(settings.port_region)})"`
`23`	`23`	`"\n# Sub-Tasks"`
`24`	`24`	`"\n" + "\n".join(tasks) + "\n",`
`25`		`- "labels": ["Port", scorecard_title, level, blueprint, entity["identifier"]],`
	`25`	`+ "labels": ["Port", scorecard.get("identifier",""), level, blueprint, entity["identifier"]],`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`def generate_task(self, rule: dict[str, Any]):`