Merge pull request #306 from port-labs/fix/permissionImport

Blueprint permission fix

Author: azeezport

port/blueprint-permissions/refreshBluePrintPermissionsToState.go

@@ -70,6 +70,10 @@ func refreshBlueprintPermissionsState(state *BlueprintPermissionsModel, a *cli.B
 		oldPermissions.UpdateProperties = &BlueprintRelationsPermissionsTFBlock{}
 	}
 
+	if oldPermissions.UpdateMetadataProperties == nil {
+		oldPermissions.UpdateMetadataProperties = &BlueprintMetadataPermissionsTFBlock{}
+	}
+
 	state.Entities.UpdateProperties = nil
 	var mappedUpdateProperties BlueprintRelationsPermissionsTFBlock = nil
 	if len(a.Entities.UpdateProperties) > 0 {

port/blueprint-permissions/refreshBluePrintPermissionsToState_test.go

@@ -0,0 +1,144 @@
+package blueprint_permissions
+
+import (
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-framework/types"
+	"github.com/port-labs/terraform-provider-port-labs/v2/internal/cli"
+)
+
+func TestRefreshBlueprintPermissionsStateWithNilUpdateMetadataProperties(t *testing.T) {
+	state := &BlueprintPermissionsModel{
+		ID:                  types.StringValue("testBlueprint"),
+		BlueprintIdentifier: types.StringValue("testBlueprint"),
+		Entities:            nil,
+	}
+
+	ownedByTeam := false
+	apiResponse := &cli.BlueprintPermissions{
+		Entities: cli.BlueprintPermissionsEntities{
+			Register: cli.BlueprintPermissionsBlock{
+				Users:       []string{},
+				Roles:       []string{"Admin"},
+				Teams:       []string{},
+				OwnedByTeam: &ownedByTeam,
+			},
+			Unregister: cli.BlueprintPermissionsBlock{
+				Users:       []string{},
+				Roles:       []string{"Admin"},
+				Teams:       []string{},
+				OwnedByTeam: &ownedByTeam,
+			},
+			Update: cli.BlueprintPermissionsBlock{
+				Users:       []string{},
+				Roles:       []string{"Admin"},
+				Teams:       []string{},
+				OwnedByTeam: &ownedByTeam,
+			},
+			UpdateProperties: cli.BlueprintRolesOrPropertiesPermissionsBlock{
+				"$title": cli.BlueprintPermissionsBlock{
+					Users:       []string{},
+					Roles:       []string{"Member"},
+					Teams:       []string{},
+					OwnedByTeam: &ownedByTeam,
+				},
+				"$identifier": cli.BlueprintPermissionsBlock{
+					Users:       []string{},
+					Roles:       []string{"Member"},
+					Teams:       []string{},
+					OwnedByTeam: &ownedByTeam,
+				},
+			},
+		},
+	}
+
+	err := refreshBlueprintPermissionsState(state, apiResponse, "testBlueprint")
+	if err != nil {
+		t.Fatalf("refreshBlueprintPermissionsState failed: %v", err)
+	}
+	if state.Entities == nil {
+		t.Fatal("Entities should not be nil after refresh")
+	}
+
+	if state.Entities.UpdateMetadataProperties == nil {
+		t.Fatal("UpdateMetadataProperties should not be nil after refresh")
+	}
+
+	if state.Entities.UpdateMetadataProperties.Title == nil {
+		t.Fatal("UpdateMetadataProperties.Title should not be nil")
+	}
+
+	if state.Entities.UpdateMetadataProperties.Identifier == nil {
+		t.Fatal("UpdateMetadataProperties.Identifier should not be nil")
+	}
+
+	if len(state.Entities.UpdateMetadataProperties.Title.Roles) != 1 {
+		t.Errorf("Expected 1 role for Title, got %d", len(state.Entities.UpdateMetadataProperties.Title.Roles))
+	}
+
+	if state.Entities.UpdateMetadataProperties.Title.Roles[0].ValueString() != "Member" {
+		t.Errorf("Expected role 'Member' for Title, got %s", state.Entities.UpdateMetadataProperties.Title.Roles[0].ValueString())
+	}
+}
+
+func TestRefreshBlueprintPermissionsStateWithExistingUpdateMetadataProperties(t *testing.T) {
+	ownedByTeam := false
+	state := &BlueprintPermissionsModel{
+		ID:                  types.StringValue("testBlueprint"),
+		BlueprintIdentifier: types.StringValue("testBlueprint"),
+		Entities: &EntitiesBlueprintPermissionsModel{
+			UpdateMetadataProperties: &BlueprintMetadataPermissionsTFBlock{
+				Title: &BlueprintPermissionsTFBlock{
+					Users:       []types.String{types.StringValue("user1@example.com")},
+					Roles:       []types.String{types.StringValue("Admin")},
+					Teams:       []types.String{},
+					OwnedByTeam: types.BoolValue(ownedByTeam),
+				},
+			},
+		},
+	}
+
+	apiResponse := &cli.BlueprintPermissions{
+		Entities: cli.BlueprintPermissionsEntities{
+			Register: cli.BlueprintPermissionsBlock{
+				Users:       []string{},
+				Roles:       []string{"Admin"},
+				Teams:       []string{},
+				OwnedByTeam: &ownedByTeam,
+			},
+			Unregister: cli.BlueprintPermissionsBlock{
+				Users:       []string{},
+				Roles:       []string{"Admin"},
+				Teams:       []string{},
+				OwnedByTeam: &ownedByTeam,
+			},
+			Update: cli.BlueprintPermissionsBlock{
+				Users:       []string{},
+				Roles:       []string{"Admin"},
+				Teams:       []string{},
+				OwnedByTeam: &ownedByTeam,
+			},
+			UpdateProperties: cli.BlueprintRolesOrPropertiesPermissionsBlock{
+				"$title": cli.BlueprintPermissionsBlock{
+					Users:       []string{"user1@example.com", "user2@example.com"},
+					Roles:       []string{"Member"},
+					Teams:       []string{},
+					OwnedByTeam: &ownedByTeam,
+				},
+			},
+		},
+	}
+
+	err := refreshBlueprintPermissionsState(state, apiResponse, "testBlueprint")
+	if err != nil {
+		t.Fatalf("refreshBlueprintPermissionsState failed: %v", err)
+	}
+
+	if state.Entities.UpdateMetadataProperties.Title == nil {
+		t.Fatal("UpdateMetadataProperties.Title should not be nil")
+	}
+
+	if len(state.Entities.UpdateMetadataProperties.Title.Users) != 2 {
+		t.Errorf("Expected 2 users for Title, got %d", len(state.Entities.UpdateMetadataProperties.Title.Users))
+	}
+}