Skip to content

listItem index is incorrect #114

Open
@rmarscher

Description

@rmarscher

It seems to be using the level or something instead of the child index.

const result = render(input, {
  components: {
    listItem: ({children, index, value}) => {
      const level = value?.level || 0
      return `<li class="level-${level}">${index + 1}. ${children}</li>`
    }
  }
})
[
  {
    "_type": "block",
    "_key": "67bc3b70ed15",
    "style": "normal",
    "markDefs": [],
    "children": [
      {
        "_type": "span",
        "_key": "48654e04fc30",
        "text": "level 1, item 1",
        "marks": []
      }
    ],
    "level": 1,
    "listItem": "bullet"
  },
  {
    "_type": "block",
    "children": [
      {
        "_type": "span",
        "text": "level 1, item 2",
        "marks": [],
        "_key": "846c462e23e3"
      }
    ],
    "markDefs": [],
    "listItem": "bullet",
    "level": 1,
    "style": "normal",
    "_key": "c550b23bbed2"
  },
  {
    "_type": "block",
    "children": [
      {
        "_type": "span",
        "text": "level 2, item 1",
        "marks": [],
        "_key": "c7eb8ed52704"
      }
    ],
    "markDefs": [],
    "listItem": "bullet",
    "level": 2,
    "style": "normal",
    "_key": "0b77c0e0057b"
  },
  {
    "_type": "block",
    "children": [
      {
        "_type": "span",
        "text": "level 2, item 2",
        "marks": [],
        "_key": "34800556b939"
      }
    ],
    "markDefs": [],
    "listItem": "bullet",
    "level": 2,
    "style": "normal",
    "_key": "7dc7705bfb23"
  },
  {
    "_type": "block",
    "children": [
      {
        "_type": "span",
        "text": "level 1, item 3",
        "marks": [],
        "_key": "6e4173ff8e36"
      }
    ],
    "markDefs": [],
    "listItem": "bullet",
    "level": 1,
    "style": "normal",
    "_key": "d0e1ab5f3839"
  }
]

produces

<ul>
  <li class="level-1">1. level 1, item 1</li>
  <li class="level-1">
    1. level 1, item 2
    <ul>
      <li class="level-2">2. level 2, item 1</li>
      <li class="level-2">2. level 2, item 2</li>
    </ul>
  </li>
  <li class="level-1">1. level 1, item 3</li>
</ul>

when the expected is

<ul>
  <li class="level-1">1. level 1, item 1</li>
  <li class="level-1">
    2. level 1, item 2
    <ul>
      <li class="level-2">1. level 2, item 1</li>
      <li class="level-2">2. level 2, item 2</li>
    </ul>
  </li>
  <li class="level-1">3. level 1, item 3</li>
</ul>

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions