fix: correct internal MCP name from 'ncp' to 'mcp' in tests and cleanup setTimeout handles

- Fixed test failures in internal-mcps-e2e.test.ts and internal-mcp-manager-indexing.test.ts
- NCPManagementMCP is registered with name 'mcp', not 'ncp'
- Added proper setTimeout cleanup in mcp-timeout-scenarios.test.ts to prevent open handles
- Store timeout IDs and clear them in afterEach to avoid Jest teardown warnings
- All affected tests now passing

Author: Arul-

tests/e2e/internal-mcps-e2e.test.ts

@@ -91,7 +91,7 @@ describe('Internal MCPs - E2E Tests', () => {
 
   describe('MCP Management MCP', () => {
     test('should list available mcp management tools', () => {
-      const mcpMCP = manager.getAllEnabledInternalMCPs().find(m => m.name === 'ncp');
+      const mcpMCP = manager.getAllEnabledInternalMCPs().find(m => m.name === 'mcp');
 
       expect(mcpMCP).toBeDefined();
       expect(mcpMCP?.tools.length).toBeGreaterThan(0);
@@ -103,7 +103,7 @@ describe('Internal MCPs - E2E Tests', () => {
     });
 
     test('should list MCPs in profile', async () => {
-      const result = await manager.executeInternalTool('ncp', 'list', {
+      const result = await manager.executeInternalTool('mcp', 'list', {
         profile: 'default'
       });
 
@@ -112,7 +112,7 @@ describe('Internal MCPs - E2E Tests', () => {
     });
 
     test('should list MCPs from specific profile', async () => {
-      const result = await manager.executeInternalTool('ncp', 'list', {
+      const result = await manager.executeInternalTool('mcp', 'list', {
         profile: 'default'
       });
 

tests/internal-mcps/internal-mcp-manager-indexing.test.ts

@@ -61,14 +61,14 @@ describe('InternalMCPManager - Index Management', () => {
 
     test('should handle multiple MCPs being disabled', async () => {
       await manager.disableInternalMCP('schedule');
-      await manager.disableInternalMCP('ncp');
+      await manager.disableInternalMCP('mcp');
 
       expect(manager.isInternalMCPDisabled('schedule')).toBe(true);
-      expect(manager.isInternalMCPDisabled('ncp')).toBe(true);
+      expect(manager.isInternalMCPDisabled('mcp')).toBe(true);
 
       const disabledList = manager.getDisabledInternalMCPs();
       expect(disabledList).toContain('schedule');
-      expect(disabledList).toContain('ncp');
+      expect(disabledList).toContain('mcp');
     });
   });
 
@@ -124,23 +124,23 @@ describe('InternalMCPManager - Index Management', () => {
 
     test('should return list of disabled MCPs', async () => {
       await manager.disableInternalMCP('schedule');
-      await manager.disableInternalMCP('ncp');
+      await manager.disableInternalMCP('mcp');
 
       const disabled = manager.getDisabledInternalMCPs();
       expect(disabled).toHaveLength(2);
       expect(disabled).toContain('schedule');
-      expect(disabled).toContain('ncp');
+      expect(disabled).toContain('mcp');
     });
 
     test('should update after enabling MCP', async () => {
       await manager.disableInternalMCP('schedule');
-      await manager.disableInternalMCP('ncp');
+      await manager.disableInternalMCP('mcp');
 
       await manager.enableInternalMCP('schedule');
 
       const disabled = manager.getDisabledInternalMCPs();
       expect(disabled).toHaveLength(1);
-      expect(disabled).toContain('ncp');
+      expect(disabled).toContain('mcp');
       expect(disabled).not.toContain('schedule');
     });
   });
@@ -153,7 +153,7 @@ describe('InternalMCPManager - Index Management', () => {
       expect(enabled.length).toBeGreaterThanOrEqual(2);
 
       const names = enabled.map(m => m.name);
-      expect(names).toContain('ncp');
+      expect(names).toContain('mcp');
       expect(names).toContain('schedule');
     });
 
@@ -163,7 +163,7 @@ describe('InternalMCPManager - Index Management', () => {
       const enabled = manager.getAllEnabledInternalMCPs();
       const names = enabled.map(m => m.name);
 
-      expect(names).toContain('ncp');
+      expect(names).toContain('mcp');
       expect(names).not.toContain('schedule');
     });
 
@@ -240,14 +240,14 @@ describe('InternalMCPManager - Index Management', () => {
 
     test('should maintain state across multiple operations', async () => {
       await manager.disableInternalMCP('schedule');
-      await manager.disableInternalMCP('ncp');
+      await manager.disableInternalMCP('mcp');
 
       expect(manager.getDisabledInternalMCPs()).toHaveLength(2);
 
       await manager.enableInternalMCP('schedule');
 
       expect(manager.getDisabledInternalMCPs()).toHaveLength(1);
-      expect(manager.getDisabledInternalMCPs()).toContain('ncp');
+      expect(manager.getDisabledInternalMCPs()).toContain('mcp');
     });
   });
 });

tests/mcp-timeout-scenarios.test.ts

@@ -8,12 +8,18 @@ import { MCPServer } from '../src/server/mcp-server.js';
 
 describe('MCP Timeout Prevention Tests', () => {
   let server: MCPServer;
+  let timeoutIds: NodeJS.Timeout[] = [];
 
   beforeEach(() => {
     server = new MCPServer('test', false);
+    timeoutIds = [];
   });
 
   afterEach(async () => {
+    // Clear all pending timeouts
+    timeoutIds.forEach(id => clearTimeout(id));
+    timeoutIds = [];
+
     if (server) {
       await server.cleanup?.();
     }
@@ -36,9 +42,10 @@ describe('MCP Timeout Prevention Tests', () => {
             method: 'tools/list'
           }),
           // Fail if any request takes more than 1 second
-          new Promise((_, reject) =>
-            setTimeout(() => reject(new Error(`Request ${i} timed out`)), 1000)
-          )
+          new Promise((_, reject) => {
+            const timeoutId = setTimeout(() => reject(new Error(`Request ${i} timed out`)), 1000);
+            timeoutIds.push(timeoutId);
+          })
         ])
       );
 
@@ -57,9 +64,10 @@ describe('MCP Timeout Prevention Tests', () => {
     });
 
     it('should respond to initialize within 100ms even with slow indexing', async () => {
-      const timeout = new Promise((_, reject) =>
-        setTimeout(() => reject(new Error('Initialize timed out')), 100)
-      );
+      const timeout = new Promise((_, reject) => {
+        const timeoutId = setTimeout(() => reject(new Error('Initialize timed out')), 100);
+        timeoutIds.push(timeoutId);
+      });
 
       const response = Promise.resolve(server.handleRequest({
         jsonrpc: '2.0',