Skip to content

Commit 120bd68

Browse files
committed
1 parent 0324779 commit 120bd68

3 files changed

Lines changed: 23 additions & 3 deletions

File tree

name.abuchen.portfolio.tests/src/name/abuchen/portfolio/datatransfer/pdf/modenaestonia/Kontoauszug03.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ Total €17.03
1313
Vault Income
1414
Date Source Amount
1515
2025-05-01 08:00:10 Vault accrued revenue €0.61
16+
2025-05-12 07:30:56 Debt claims buyback €-0.00
1617
Bond Interest Income
1718
3
1819
Income statement

name.abuchen.portfolio.tests/src/name/abuchen/portfolio/datatransfer/pdf/modenaestonia/ModenaEstoniaPDFExtractorTest.java

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import static name.abuchen.portfolio.datatransfer.ExtractorMatchers.hasSource;
88
import static name.abuchen.portfolio.datatransfer.ExtractorMatchers.interest;
99
import static name.abuchen.portfolio.datatransfer.ExtractorMatchers.interestCharge;
10+
import static name.abuchen.portfolio.datatransfer.ExtractorMatchers.withFailureMessage;
1011
import static name.abuchen.portfolio.datatransfer.ExtractorTestUtilities.countAccountTransactions;
1112
import static name.abuchen.portfolio.datatransfer.ExtractorTestUtilities.countBuySell;
1213
import static name.abuchen.portfolio.datatransfer.ExtractorTestUtilities.countSecurities;
@@ -20,6 +21,7 @@
2021

2122
import org.junit.Test;
2223

24+
import name.abuchen.portfolio.Messages;
2325
import name.abuchen.portfolio.datatransfer.actions.AssertImportActions;
2426
import name.abuchen.portfolio.datatransfer.pdf.ModenaEstoniaPDFExtractor;
2527
import name.abuchen.portfolio.datatransfer.pdf.PDFInputFile;
@@ -98,12 +100,21 @@ public void testKontoauszug03()
98100
assertThat(errors, empty());
99101
assertThat(countSecurities(results), is(0L));
100102
assertThat(countBuySell(results), is(0L));
101-
assertThat(countAccountTransactions(results), is(1L));
102-
assertThat(results.size(), is(1));
103+
assertThat(countAccountTransactions(results), is(2L));
104+
assertThat(results.size(), is(2));
103105
new AssertImportActions().check(results, "EUR");
104106

105107
// assert transaction
106108
assertThat(results, hasItem(interest(hasDate("2025-05-01T08:00:10"), hasAmount("EUR", 0.61), //
107109
hasSource("Kontoauszug03.txt"), hasNote("Vault accrued revenue"))));
110+
111+
// assert transaction
112+
assertThat(results, hasItem(withFailureMessage( //
113+
Messages.MsgErrorTransactionTypeNotSupported, //
114+
interestCharge( //
115+
hasDate("2025-05-12T07:30:56"), //
116+
hasSource("Kontoauszug03.txt"), //
117+
hasNote("Debt claims buyback"), //
118+
hasAmount("EUR", 0.00)))));
108119
}
109120
}

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/ModenaEstoniaPDFExtractor.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import static name.abuchen.portfolio.util.TextUtil.trim;
44

5+
import name.abuchen.portfolio.Messages;
56
import name.abuchen.portfolio.datatransfer.ExtractorUtils;
67
import name.abuchen.portfolio.datatransfer.pdf.PDFParser.Block;
78
import name.abuchen.portfolio.datatransfer.pdf.PDFParser.DocumentType;
@@ -102,7 +103,14 @@ private void addAccountStatementTransaction()
102103
t.setNote(trim(v.get("note")));
103104
})
104105

105-
.wrap(TransactionItem::new);
106+
.wrap(t -> {
107+
var item = new TransactionItem(t);
108+
109+
if (t.getCurrencyCode() != null && t.getAmount() == 0)
110+
item.setFailureMessage(Messages.MsgErrorTransactionTypeNotSupported);
111+
112+
return item;
113+
});
106114
}
107115

108116
@Override

0 commit comments

Comments
 (0)