Skip to content

Commit 3937be7

Browse files
Konilobuchen
authored andcommitted
Move plugin versions into properties section
All hardcoded plugin versions in portfolio-app/pom.xml are now declared in <properties> as ${<artifactId>.version} placeholders, matching the existing ${tycho-version} pattern. Makes outdated plugins easier to spot via `mvn versions:display-plugin-updates`. The checkstyle dependency version inside maven-checkstyle-plugin is intentionally left hardcoded since it is not a plugin version. Issue: #3244 Issue: #5717
1 parent 9a35127 commit 3937be7

1 file changed

Lines changed: 22 additions & 11 deletions

File tree

portfolio-app/pom.xml

Lines changed: 22 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,17 @@
1414
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
1515
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
1616
<tycho-version>5.0.3</tycho-version>
17+
<maven-enforcer-plugin.version>3.6.3</maven-enforcer-plugin.version>
18+
<maven-resources-plugin.version>3.5.0</maven-resources-plugin.version>
19+
<maven-dependency-plugin.version>3.11.0</maven-dependency-plugin.version>
20+
<maven-jarsigner-plugin.version>3.1.0</maven-jarsigner-plugin.version>
21+
<maven-gpg-plugin.version>3.2.8</maven-gpg-plugin.version>
22+
<maven-checkstyle-plugin.version>3.6.0</maven-checkstyle-plugin.version>
23+
<sonar-maven-plugin.version>5.7.0.6970</sonar-maven-plugin.version>
24+
<fix-info-plist-maven-plugin.version>1.8</fix-info-plist-maven-plugin.version>
25+
<exec-maven-plugin.version>3.6.3</exec-maven-plugin.version>
26+
<jacoco-maven-plugin.version>0.8.14</jacoco-maven-plugin.version>
27+
<protoc-jar-maven-plugin.version>3.11.4</protoc-jar-maven-plugin.version>
1728
<jarsigner.skip>true</jarsigner.skip>
1829
<gpgsigner.skip>true</gpgsigner.skip>
1930
<applesigner.skip>true</applesigner.skip>
@@ -106,7 +117,7 @@
106117
<plugin>
107118
<groupId>org.apache.maven.plugins</groupId>
108119
<artifactId>maven-enforcer-plugin</artifactId>
109-
<version>3.6.3</version>
120+
<version>${maven-enforcer-plugin.version}</version>
110121
<executions>
111122
<execution>
112123
<id>enforce-versions</id>
@@ -462,15 +473,15 @@
462473
<plugin>
463474
<groupId>org.apache.maven.plugins</groupId>
464475
<artifactId>maven-resources-plugin</artifactId>
465-
<version>3.5.0</version>
476+
<version>${maven-resources-plugin.version}</version>
466477
<configuration>
467478
<encoding>UTF-8</encoding>
468479
</configuration>
469480
</plugin>
470481
<plugin>
471482
<groupId>org.apache.maven.plugins</groupId>
472483
<artifactId>maven-dependency-plugin</artifactId>
473-
<version>3.11.0</version>
484+
<version>${maven-dependency-plugin.version}</version>
474485
</plugin>
475486
<plugin>
476487
<groupId>org.eclipse.tycho</groupId>
@@ -530,7 +541,7 @@
530541
<plugin>
531542
<groupId>org.apache.maven.plugins</groupId>
532543
<artifactId>maven-jarsigner-plugin</artifactId>
533-
<version>3.1.0</version>
544+
<version>${maven-jarsigner-plugin.version}</version>
534545
<executions>
535546
<execution>
536547
<id>sign</id>
@@ -562,12 +573,12 @@
562573
<plugin>
563574
<groupId>org.apache.maven.plugins</groupId>
564575
<artifactId>maven-gpg-plugin</artifactId>
565-
<version>3.2.8</version>
576+
<version>${maven-gpg-plugin.version}</version>
566577
</plugin>
567578
<plugin>
568579
<groupId>org.apache.maven.plugins</groupId>
569580
<artifactId>maven-checkstyle-plugin</artifactId>
570-
<version>3.6.0</version>
581+
<version>${maven-checkstyle-plugin.version}</version>
571582
<dependencies>
572583
<dependency>
573584
<groupId>com.puppycrawl.tools</groupId>
@@ -596,17 +607,17 @@
596607
<plugin>
597608
<groupId>org.sonarsource.scanner.maven</groupId>
598609
<artifactId>sonar-maven-plugin</artifactId>
599-
<version>5.7.0.6970</version>
610+
<version>${sonar-maven-plugin.version}</version>
600611
</plugin>
601612
<plugin>
602613
<groupId>name.abuchen</groupId>
603614
<artifactId>fix-info-plist-maven-plugin</artifactId>
604-
<version>1.8</version>
615+
<version>${fix-info-plist-maven-plugin.version}</version>
605616
</plugin>
606617
<plugin>
607618
<groupId>org.codehaus.mojo</groupId>
608619
<artifactId>exec-maven-plugin</artifactId>
609-
<version>3.6.3</version>
620+
<version>${exec-maven-plugin.version}</version>
610621
<configuration>
611622
<mainClass>name.abuchen.portfolio.build.MessagesTool</mainClass>
612623
<classpathScope>runtime</classpathScope>
@@ -619,12 +630,12 @@
619630
<plugin>
620631
<groupId>org.jacoco</groupId>
621632
<artifactId>jacoco-maven-plugin</artifactId>
622-
<version>0.8.14</version>
633+
<version>${jacoco-maven-plugin.version}</version>
623634
</plugin>
624635
<plugin>
625636
<groupId>com.github.os72</groupId>
626637
<artifactId>protoc-jar-maven-plugin</artifactId>
627-
<version>3.11.4</version>
638+
<version>${protoc-jar-maven-plugin.version}</version>
628639
</plugin>
629640
</plugins>
630641
</pluginManagement>

0 commit comments

Comments
 (0)