Fix Bison PDF-Importer Staking Reward (#4747)

Closes #4717

Author: Nirus2000

name.abuchen.portfolio.tests/src/name/abuchen/portfolio/datatransfer/pdf/bison/BisonPDFExtractorTest.java

@@ -313,9 +313,9 @@ public void testInfoReport04()
 
         assertThat(errors, empty());
         assertThat(countSecurities(results), is(2L));
-        assertThat(countBuySell(results), is(4L));
+        assertThat(countBuySell(results), is(2L));
         assertThat(countAccountTransactions(results), is(3L));
-        assertThat(results.size(), is(9));
+        assertThat(results.size(), is(7));
         new AssertImportActions().check(results, "EUR");
 
         // check security
@@ -337,14 +337,6 @@ public void testInfoReport04()
         assertThat(results, hasItem(deposit(hasDate("2025-02-03T20:17"), hasAmount("EUR", 53.00), //
                         hasSource("InfoReport04.txt"), hasNote(null))));
 
-        // check buy sell transaction
-        assertThat(results, hasItem(purchase( //
-                        hasDate("2025-02-03T08:48"), hasShares(0.00000541), //
-                        hasSource("InfoReport04.txt"), //
-                        hasNote(null), //
-                        hasAmount("EUR", 0.02), hasGrossValue("EUR", 0.02), //
-                        hasTaxes("EUR", 0.00), hasFees("EUR", 0.00))));
-
         // check inbound delivery transactions
         assertThat(results, hasItem(inboundDelivery( //
                         hasDate("2025-02-03T08:48"), hasShares(0.00000541), //
@@ -369,14 +361,6 @@ public void testInfoReport04()
                         hasAmount("EUR", 8.40), hasGrossValue("EUR", 8.40), //
                         hasTaxes("EUR", 0.00), hasFees("EUR", 0.00))));
 
-        // check buy sell transaction
-        assertThat(results, hasItem(purchase( //
-                        hasDate("2025-01-27T07:50"), hasShares(0.00000150), //
-                        hasSource("InfoReport04.txt"), //
-                        hasNote(null), //
-                        hasAmount("EUR", 0.00), hasGrossValue("EUR", 0.00), //
-                        hasTaxes("EUR", 0.00), hasFees("EUR", 0.00))));
-
         // check inbound delivery transactions
         assertThat(results, hasItem(inboundDelivery( //
                         hasDate("2025-01-27T07:50"), hasShares(0.00000150), //

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/BisonPDFExtractor.java

@@ -14,8 +14,8 @@
  * @formatter:off
  * @implNote Importer for "Info Reports" produced by the Bison App.
  *
- * @implSpec Bison only supports EUR as currency. Therefore the extractor is always
- *           defaulting to EUR.
+ * @implSpec Bison only supports EUR as currency. 
+ *           Therefore the extractor is always defaulting to EUR.
  * @formatter:on
  */
 @SuppressWarnings("nls")
@@ -46,7 +46,7 @@ private void addBuyCryptoTransaction()
 
         var pdfTransaction = new Transaction<BuySellEntry>();
 
-        var firstRelevantLine = new Block("^(Kauf|Verkauf|Staking Reward)[\\*]* [A-Z0-9]{1,5}(?:[\\-\\/][A-Z0-9]{1,5})? [\\.,\\d]+$");
+        var firstRelevantLine = new Block("^(Kauf|Verkauf)[\\*]* [A-Z0-9]{1,5}(?:[\\-\\/][A-Z0-9]{1,5})? [\\.,\\d]+$");
         type.addBlock(firstRelevantLine);
         firstRelevantLine.set(pdfTransaction);
 
@@ -60,7 +60,7 @@ private void addBuyCryptoTransaction()
 
                         // Is type --> "Verkauf" change from BUY to SELL
                         .section("type").optional() //
-                        .match("^(?<type>(Kauf|Verkauf|Staking Reward))[\\*]* [A-Z0-9]{1,5}(?:[\\-\\/][A-Z0-9]{1,5})? [\\.,\\d]+$") //
+                        .match("^(?<type>(Kauf|Verkauf))[\\*]* [A-Z0-9]{1,5}(?:[\\-\\/][A-Z0-9]{1,5})? [\\.,\\d]+$") //
                         .assign((t, v) -> {
                             if ("Verkauf".equals(v.get("type"))) //
                                 t.setType(PortfolioTransaction.Type.SELL);
@@ -75,12 +75,9 @@ private void addBuyCryptoTransaction()
                         //
                         // Verkauf* ETH 0,03396843
                         // 12.06.2022 21:19 1.401,94 €/ETH + 47,62 €
-                        //
-                        // Staking Reward ETH 0,00000541
-                        // 03.02.2025 08:48 3.011,63 €/ETH + 0,02 €
                         // @formatter:on
                         .section("tickerSymbol", "shares", "date", "time", "amount", "currency") //
-                        .match("^(Kauf|Verkauf|Staking Reward)[\\*]* (?<tickerSymbol>[A-Z0-9]{1,5}(?:[\\-\\/][A-Z0-9]{1,5})?) (?<shares>[\\.,\\d]+)$") //
+                        .match("^(Kauf|Verkauf)[\\*]* (?<tickerSymbol>[A-Z0-9]{1,5}(?:[\\-\\/][A-Z0-9]{1,5})?) (?<shares>[\\.,\\d]+)$") //
                         .match("^(?<date>[\\d]{2}\\.[\\d]{2}\\.[\\d]{4}) (?<time>[\\d]{2}:[\\d]{2}) .* (?<amount>[\\.,\\d]+) (?<currency>\\p{Sc})$") //
                         .assign((t, v) -> {
                             t.setSecurity(getOrCreateCryptoCurrency(v));