Repository navigation
Conversation
Member
Author
|
Thanks for maintaining btw! I'm planning to submit the next version of S7 to CRAN on November 16 (see RConsortium/S7#786). Would you be able to merge these compatibility changes and submit an updated version of btw to CRAN before then? Please let me know if you need more time or if there’s anything I can help with. |
Collaborator
|
Thanks @t-kalinowski -- I'll try to make the Nov 16 deadline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty context from
btw()fails when its empty string is forwarded positionally to the parent constructor, and NEWS extraction fails whenas.characterremains an S7 external-generic sentinel. Name thetextargument and clean external generic bindings after method registration.Use S7’s load, unload, and build hooks when available, retaining
methods_register()for older releases. On development S7, unloading removes the package’s external S7 methods and dependency hooks, and the build hook cleans external generic bindings after method declarations.