Skip to content

feature / improvement request to check for BEMIT and more #117

Open
@gael-boyenval

Description

Hi, this was initially posted as an issue in stylelint repo.

Feature : a customizable BEMIT selector syntax checker

the BEM linter is great but it doesn't allow to customize enough to enforce BEMIT @csswizardry (Harry Roberts) proposal.

a great article about BEMIT here or for the lazy ones : BEMIT Cheatsheet

it's about namespaced BEM selectors, and enforce different rules for those deferents types.

some of the BEMIT types:

  • scope .s-
  • themes .t-
  • components .c-
  • states .is- | .has- | .no- ...

some "types" can be combined :
.c-component.is-open => ok

but others not :
.c-component-a .c-component-b => warn

implementing a strict ruleset would be great but being able to configure it and create our own would be even better :

{
    // basic syntax checker, create your own flavor of BEM if you want
    generalSyntax: {
        wordDelimiterStyle: 'lowerCamelCase' | 'CamelCase'  | 'snake_case' | 'kebab-case' | 'min' | 'CAPS',
        modifierDelimiter: '__' | regex,
        elementDelimiter: '__' | regex
    },
    registerTypes: [
        {
            name: 'components', // the name of the type
            namespaces: .c-|.custom-|.other-|, // a regex to match namespaces,
            canCallClassType: ['states'] | 'any', // array of registred types that can be called in a selector`.c-popup.is-open`
            allowHostDiferentBlock: false // disalow `.c-carousel__nav .c-btn`
        },{
            name: 'states',
            namespaces: .is-|.has-|.no-|,
            canCallClassType: 'any',
        },{
            name: 'utilities',
            namespaces: /.is-|.has-|.no-|/ regex,
            canCallClassType: ['registredName'] | 'any' | 'none',
        },{
            name: 'themes',
            namespaces: /.t-/ regex,
            canCallClassType: 'any', // allow '.t-dark .c-btn--alert' selector
        },{
            name: 'scopes',
            namespaces: /.t-/ regex,
            canCallClassType: 'any',
        }
        ...
    ]
}

each selectors would be evaluated, the first class would be considered has the "host" and all other has "hosted" :

exemple :

with the given registered types :

      {
            name: 'components',
            namespaces: 'c-',
            canCallClassType: ['states'],
            allowHostDiferentBlock: false
        },{
            name: 'states',
            namespaces: 'is-|has-|no-',
            canCallClassType: any,
            allowHostDiferentBlock: true
        },{
            name: 'hacks',
            namespaces: '_',
            canCallClassType: any,
            allowHostDiferentBlock: true
        }
...

lint results :

.c-slider__nav .c-btn {} 
/* warn 'a component cannot host another component' */
.c-popup.is-open {} 
/* good */
.c-popup .anyothernamespace-anyblockname {} 
/* warn 'this element should have a registered type/namespace' */
/* warn 'a component cannot host  anyothernamespace' */
.x-block {} 
/* warn 'this element should have a registered type/namespace' */
._hack .someExternalComponent {} 
/* good */

there is obviously many uses case that are not taken in account here, and the naming conventions that I used is certainly not the best, but you get the spirit…

I'm not very confident that you would agree to change so much of your plugin's philosophy to match those requirements, but I was wondering about forking your repo and maybe build on top of what's have already been accomplished here.

It would be very nice of you to point me to the right direction. :)

Maybe some peoples would be interested to work with me on that to.

cheers :)

GB

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions