fix: ensure reproducible builds (deterministic versionCode and base path)

Author: potatameister

.github/workflows/android-release.yml

@@ -23,8 +23,6 @@ jobs:
 
       - name: Build Web Assets (Vite)
         run: npm run build
-        env:
-          CAPACITOR_BUILD: 'true'
 
       - name: Generate Android Assets (Icon/Splash)
         run: npx -y @capacitor/assets generate --android
@@ -44,18 +42,11 @@ jobs:
       - name: Sync Capacitor
         run: npx cap sync android
 
-      - name: Set Version Code
-        run: echo "ANDROID_VERSION_CODE=$((GITHUB_RUN_NUMBER + 100))" >> $GITHUB_ENV
-        env:
-          GITHUB_RUN_NUMBER: ${{ github.run_number }}
-
       - name: Build with Gradle
         run: |
           cd android
           chmod +x gradlew
           ./gradlew assembleRelease
-        env:
-          ANDROID_VERSION_CODE: ${{ env.ANDROID_VERSION_CODE }}
 
       - name: Sign APK
         id: sign_app

.github/workflows/deploy.yml

@@ -25,6 +25,8 @@ jobs:
 
       - name: Build
         run: npm run build
+        env:
+          VITE_BASE: /PaperKnife/
 
       - name: Deploy
         uses: JamesIves/github-pages-deploy-action@v4

android/app/build.gradle

@@ -1,14 +1,23 @@
 apply plugin: 'com.android.application'
 
+import groovy.json.JsonSlurper
+
+def getPackageJson() {
+    def inputFile = new File(project.rootDir, '../package.json')
+    return new JsonSlurper().parseText(inputFile.text)
+}
+
+def packageJson = getPackageJson()
+
 android {
-    namespace = "com.paperknife.app"
-    compileSdk = rootProject.ext.compileSdkVersion
+    namespace "com.paperknife.app"
+    compileSdk rootProject.ext.compileSdkVersion
     defaultConfig {
         applicationId "com.paperknife.app"
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
-        versionCode 101
-        versionName "1.0.1"
+        versionCode (packageJson.version.split('-')[0].split('\\.').collect { it.toInteger() }.with { (it[0] * 10000) + (it[1] * 100) + it[2] })
+        versionName packageJson.version
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         aaptOptions {
              // Files and dirs to omit from the packaged assets dir, modified to accommodate modern web apps.

vite.config.ts

@@ -6,7 +6,7 @@ export default defineConfig({
   plugins: [
     react()
   ],
-  base: process.env.CAPACITOR_BUILD === 'true' ? './' : '/PaperKnife/',
+  base: process.env.VITE_BASE || './',
   server: {
     host: true
   },