Skip to content

Commit 9187261

Browse files
committed
Remove intermediate columns in arith machines.
1 parent 0f442ea commit 9187261

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

std/machines/large_field/arith256_memory.asm

+5-8
Original file line numberDiff line numberDiff line change
@@ -498,14 +498,11 @@ machine Arith256Memory(mem: Memory) with
498498
*
499499
*******/
500500

501-
// TODO: To reduce the degree of the constraints, these intermediate columns should be materialized.
502-
// However, witgen doesn't work currently if we do, likely because for some operations, not all inputs are
503-
// available.
504-
col eq0_sum = sum(32, |i| eq0(i) * CLK32[i]);
505-
col eq1_sum = sum(32, |i| eq1(i) * CLK32[i]);
506-
col eq2_sum = sum(32, |i| eq2(i) * CLK32[i]);
507-
col eq3_sum = sum(32, |i| eq3(i) * CLK32[i]);
508-
col eq4_sum = sum(32, |i| eq4(i) * CLK32[i]);
501+
let eq0_sum = sum(32, |i| eq0(i) * CLK32[i]);
502+
let eq1_sum = sum(32, |i| eq1(i) * CLK32[i]);
503+
let eq2_sum = sum(32, |i| eq2(i) * CLK32[i]);
504+
let eq3_sum = sum(32, |i| eq3(i) * CLK32[i]);
505+
let eq4_sum = sum(32, |i| eq4(i) * CLK32[i]);
509506

510507
selEq[0] * (eq0_sum + carry[0]) = selEq[0] * carry[0]' * 2**16;
511508
selEq[1] * (eq1_sum + carry[0]) = selEq[1] * carry[0]' * 2**16;

std/machines/small_field/arith256.asm

+1-1
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ machine Arith256 with
141141
*
142142
*******/
143143
144-
col eq0_sum = sum(64, |i| eq0(i) * CLK64[i]);
144+
let eq0_sum = sum(64, |i| eq0(i) * CLK64[i]);
145145

146146
eq0_sum + carry = carry' * 2**8;
147147
}

0 commit comments

Comments
 (0)