[PBIOS-701]Updates to PBAvatar #530
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachelRadford21
added
improvement
isismsilva
reviewed
Apr 4, 2025
| @@ -63,7 +63,7 @@ public struct PBAvatar: View { | |||
|
|
|||
|
|
|||
| if let status = self.status { | |||
| PBOnlineStatus(status: status, size: statusSize, variant: .border) | |||
| PBOnlineStatus(status: status, size: statusSize ?? avatarStatusSize, variant: .border) | |||
There was a problem hiding this comment.
What is going to happen when the Online status get a nil value here?
Is that the expected behavior?
There was a problem hiding this comment.
@isismsilva
I have the default set to medium, if it's nil. If you think it should default to something else or this is incorrect, lmk
There was a problem hiding this comment.
I think this needs to be a design decision. Let's ask Jess to make sure how it is supposed to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[PBIOS-701]Updates to PBAvatar
https://runway.powerhrg.com/backlog_items/PBIOS-701
Checklist
breaking,bug,improvement,documentation, orenhancement. See Labels for descriptions.Ready for Testing/Ready for Release