Commit 9d74a9b
authored
[PLAY-2509] Playbook Website: Accessibility Updates to new Tokens/Global Props pages (#5648)
**What does this PR do?** A clear and concise description with your
runway ticket url.
[PLAY-2509](https://runway.powerhrg.com/backlog_items/PLAY-2509) makes
some Accessibility updates for some of our new Website pages.
Accessibility evaluated with Firefox's accessibility tools, Safari's
accessibility tools, and MacOS' VoiceOver Screenreader.
This PR addresses:
- Tokens and Global Props index page - removing Title surrounding
arrow-right-long icon removed "headings should have visible text
content" warning.
- Colors Token Page - adding firstColumnBold=false removed a Heading
“headings must be labeled” warning.
- ExampleCodeCard - adjusting the logic here removed "generic: clickable
elements must be focusable and should have interactive semantics" from
copiable and non-copiable example segments while preserving their look
(also makes the copiable ones keyboard interactive!)
- Footer - Large Powergon no longer has "Text Labels and Names content
with images must be labeled" warning.
- /beta/kits page - added Aria to the React/Rails/Swift SVGs in the
Nav/Search section to remove "Content with images must be labeled"
warning
Not easily solvable so left untouched:
- Footer - the GitHub icon in the footer button still has a "Text Labels
and Names content with images must be labeled" warning - unable to
access this icon/add aria on it from the kit.
- Dark Global Prop page - accessibility warnings on the Selectable Cards
in the examples (related to the structure of the kit itself see
[PLAY-2421](https://runway.powerhrg.com/backlog_items/PLAY-2421) not
solvable now without using diff examples).
- /beta/kits search bar - has a "Text Labels and Names Form elements
should have a visible text label" - not fixable without a design update
so did not touch here.
**Screenshots:** Screenshots to visualize your addition/change
<img width="205" height="202" alt="powergon resolved"
src="https://github.com/user-attachments/assets/6a0f8095-4392-4e36-99d2-c0c35f42b11f"
/>
<img width="708" height="642" alt="arrow resolved"
src="https://github.com/user-attachments/assets/96d245b6-31bb-4bef-9857-6137b30bc9df"
/>
<img width="869" height="711" alt="color resolved"
src="https://github.com/user-attachments/assets/03e7fcb6-c62b-4e1e-b4b2-1d69a744d203"
/>
<img width="1624" height="530" alt="cursor values resolved"
src="https://github.com/user-attachments/assets/8a3521b7-f2fa-4ca9-bdbf-f61da92baa10"
/>
<img width="1592" height="571" alt="cursor example resolved"
src="https://github.com/user-attachments/assets/13292fae-b282-4411-ba3c-f769ed555fbc"
/>
<img width="895" height="390" alt="react icon resolved"
src="https://github.com/user-attachments/assets/65241566-365c-497d-88ee-c5a83856e056"
/>
**How to test?** Steps to confirm the desired behavior:
1. Go to the Tokens index page in the review env in Firefox. Open
accessibility tools and evaluate the page. See resolution of warnings
compared to prod on the arrow icon and Powergon icon. Open in Safari and
run accessibility check - only main warning should be the old sidebar
Typeahead element.
2. Go to the Global Props index page and evaluate the same way as 1.
3. Go to the Colors Token page and evaluate the first column
(ColorSwatch) vs. prod with accessibility tools.
4. Go to any Token or Global Prop page with ExampleCodeCard elements for
Values, React/Rails Examples, or Responsive examples, and evaluate vs.
prod with accessibility tools.
5. Go the /beta/kits page and
#### Checklist:
- [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new
kit`, `deprecated`, or `breaking`. See [Changelog &
Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels)
for details.
- [x] **DEPLOY** I have added the `milano` label to show I'm ready for a
review.
~~- [ ] **TESTS** I have added test coverage to my code.~~
- [x] **SEMVER** I have added a `minor`, `major`, or `patch` label for
release.
- [x] **RC** I have added an `inactive RC` label if not an active RC.1 parent 42f2036 commit 9d74a9b
8 files changed
Lines changed: 60 additions & 33 deletions
File tree
- playbook-website/app
- javascript/components
- GlobalPropsAndTokens
- ExamplesPage/Examples
- Templates/Subcomponents
- Website/src/components/KitFilter
- views/layouts
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| |||
110 | 111 | | |
111 | 112 | | |
112 | 113 | | |
| 114 | + | |
113 | 115 | | |
114 | 116 | | |
115 | 117 | | |
| |||
131 | 133 | | |
132 | 134 | | |
133 | 135 | | |
| 136 | + | |
134 | 137 | | |
135 | 138 | | |
136 | 139 | | |
| |||
193 | 196 | | |
194 | 197 | | |
195 | 198 | | |
| 199 | + | |
196 | 200 | | |
197 | 201 | | |
198 | 202 | | |
| |||
271 | 275 | | |
272 | 276 | | |
273 | 277 | | |
| 278 | + | |
274 | 279 | | |
275 | 280 | | |
276 | 281 | | |
| |||
357 | 362 | | |
358 | 363 | | |
359 | 364 | | |
| 365 | + | |
360 | 366 | | |
361 | 367 | | |
362 | 368 | | |
| |||
403 | 409 | | |
404 | 410 | | |
405 | 411 | | |
| 412 | + | |
406 | 413 | | |
407 | 414 | | |
408 | 415 | | |
| |||
545 | 552 | | |
546 | 553 | | |
547 | 554 | | |
| 555 | + | |
548 | 556 | | |
549 | 557 | | |
550 | 558 | | |
| |||
615 | 623 | | |
616 | 624 | | |
617 | 625 | | |
| 626 | + | |
618 | 627 | | |
619 | 628 | | |
620 | 629 | | |
| |||
789 | 798 | | |
790 | 799 | | |
791 | 800 | | |
| 801 | + | |
792 | 802 | | |
793 | 803 | | |
794 | 804 | | |
| |||
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | | - | |
58 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
59 | 61 | | |
60 | 62 | | |
61 | 63 | | |
| |||
Lines changed: 36 additions & 23 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
26 | | - | |
27 | | - | |
28 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
29 | 33 | | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
35 | 43 | | |
36 | 44 | | |
37 | 45 | | |
38 | | - | |
39 | 46 | | |
| 47 | + | |
40 | 48 | | |
41 | | - | |
42 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
43 | 58 | | |
44 | 59 | | |
45 | 60 | | |
46 | 61 | | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
58 | 71 | | |
59 | 72 | | |
60 | 73 | | |
| |||
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | | - | |
58 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
59 | 61 | | |
60 | 62 | | |
61 | 63 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
0 commit comments