Checkstyles corrections

Signed-off-by: Riad Benradi <riad.benradi_externe@rte-france.com>

Author: Riad Benradi

security-analysis/mixed-security-analysis/src/main/java/com/powsybl/mixed/security/analysis/MixedSecurityAnalysis.java

@@ -58,8 +58,7 @@ public MixedSecurityAnalysis(Network network, String workingVariantId, Contingen
      */
     public CompletableFuture<SecurityAnalysisReport> run() {
         LOGGER.info("Starting mixed-mode security analysis");
-        LOGGER.debug("Static simulator: {}, Dynamic simulator: {}", 
-            extension.getStaticSimulator(), extension.getDynamicSimulator());
+        LOGGER.debug("Static simulator: {}, Dynamic simulator: {}", extension.getStaticSimulator(), extension.getDynamicSimulator());
 
         // Step 1: Get all contingencies
         List<Contingency> allContingencies = contingenciesProvider.getContingencies(network);
@@ -70,16 +69,15 @@ public CompletableFuture<SecurityAnalysisReport> run() {
         SecurityAnalysisProvider staticProvider = findProvider(staticProviderName);
 
         CompletableFuture<SecurityAnalysisReport> staticAnalysisFuture = staticProvider.run(
-                network, workingVariantId, contingenciesProvider, runParameters);
+            network, workingVariantId, contingenciesProvider, runParameters);
 
         // Step 3: Chain dynamic analysis based on static results
         return staticAnalysisFuture.thenCompose(staticReport -> {
             LOGGER.info("Static analysis completed");
-            
             // Evaluate switch criteria
             AnalysisSwitchCriteria switchCriteria = new AnalysisSwitchCriteria(extension);
             List<String> contingenciesToRunDynamic = identifyDynamicContingencies(
-                    staticReport.getResult(), switchCriteria);
+                staticReport.getResult(), switchCriteria);
 
             LOGGER.info("Contingencies requiring dynamic analysis: {}", contingenciesToRunDynamic.size());
 
@@ -91,7 +89,7 @@ public CompletableFuture<SecurityAnalysisReport> run() {
 
             // Run dynamic analysis on filtered contingencies
             return runDynamicAnalysis(contingenciesToRunDynamic, allContingencies)
-                    .thenApply(dynamicReport -> mergeResults(staticReport, dynamicReport));
+                .thenApply(dynamicReport -> mergeResults(staticReport, dynamicReport));
         }).exceptionally(ex -> {
             LOGGER.error("Error during mixed-mode security analysis", ex);
             return new SecurityAnalysisReport(SecurityAnalysisResult.empty());
@@ -114,8 +112,7 @@ private List<String> identifyDynamicContingencies(SecurityAnalysisResult staticR
      */
     private boolean shouldRunDynamic(PostContingencyResult result, AnalysisSwitchCriteria switchCriteria) {
         SwitchDecision decision = switchCriteria.evaluate(result);
-        LOGGER.debug("Contingency {} - Switch decision: {}", 
-            result.getContingency().getId(), decision.getReason());
+        LOGGER.debug("Contingency {} - Switch decision: {}", result.getContingency().getId(), decision.getReason());
         return decision.shouldSwitch();
     }
 
@@ -127,10 +124,10 @@ private CompletableFuture<SecurityAnalysisReport> runDynamicAnalysis(List<String
                                                                           List<Contingency> allContingencies) {
         LOGGER.info("Starting dynamic analysis pass for {} contingencies", contingencyIds.size());
 
-        ContingenciesProvider filteredProvider = (net) ->
-                allContingencies.stream()
-                .filter(c -> contingencyIds.contains(c.getId()))
-                .collect(Collectors.toList());
+        ContingenciesProvider filteredProvider = network ->
+            allContingencies.stream()
+            .filter(c -> contingencyIds.contains(c.getId()))
+            .collect(Collectors.toList());
 
         String dynamicProviderName = extension.getDynamicSimulator();
         SecurityAnalysisProvider dynamicProvider = findProvider(dynamicProviderName);
@@ -144,10 +141,8 @@ private CompletableFuture<SecurityAnalysisReport> runDynamicAnalysis(List<String
      * - If analyzed in dynamic pass: use dynamic result
      * - Otherwise: use static result
      */
-    private SecurityAnalysisReport mergeResults(SecurityAnalysisReport staticReport, 
-                                                SecurityAnalysisReport dynamicReport) {
+    private SecurityAnalysisReport mergeResults(SecurityAnalysisReport staticReport, SecurityAnalysisReport dynamicReport) {
         LOGGER.info("Merging static and dynamic analysis results");
-
         SecurityAnalysisResult staticResult = staticReport.getResult();
         SecurityAnalysisResult dynamicResult = dynamicReport.getResult();
 
@@ -206,4 +201,4 @@ private SecurityAnalysisProvider findProvider(String providerName) {
         }
         return foundProvider;
     }
-}
+}

security-analysis/mixed-security-analysis/src/main/java/com/powsybl/mixed/security/analysis/MixedSecurityAnalysisProvider.java

@@ -63,7 +63,7 @@ public CompletableFuture<SecurityAnalysisReport> run(Network network,
         LOGGER.info("Starting mixed-mode security analysis for network: {}", network.getId());
 
         MixedModeParametersExtension extension = runParameters.getSecurityAnalysisParameters().getExtension(MixedModeParametersExtension.class);
-        if(extension == null) {
+        if (extension == null) {
 
             LOGGER.warn("MixedModeParametersExtension configuration is missing from SecurityAnalysisRunParameters, using defaults.");
             extension = (MixedModeParametersExtension) loadSpecificParameters(PlatformConfig.defaultConfig()).orElseThrow(() ->

security-analysis/mixed-security-analysis/src/main/java/com/powsybl/mixed/security/analysis/criteria/AnalysisSwitchCriteria.java

@@ -12,12 +12,16 @@
  *
  * @author Riad Benradi {@literal <riad.benradi at rte-france.com>}
  */
+
 public class AnalysisSwitchCriteria {
+
     private static final Logger LOGGER = LoggerFactory.getLogger(AnalysisSwitchCriteria.class);
     private final MixedModeParametersExtension extension;
+
     public AnalysisSwitchCriteria(MixedModeParametersExtension extension) {
         this.extension = Objects.requireNonNull(extension);
     }
+
     public SwitchDecision evaluate(PostContingencyResult result) {
         Objects.requireNonNull(result);
         if (extension.getSwitchCriteria() == null || extension.getSwitchCriteria().isEmpty()) {
@@ -31,6 +35,7 @@ public SwitchDecision evaluate(PostContingencyResult result) {
         }
         return new SwitchDecision(false, "No criteria met");
     }
+
     private boolean evaluateCriterion(PostContingencyResult result, String criterion) {
         return switch (criterion.toUpperCase()) {
             case "FAILED" -> evaluateNonConvergence(result);
@@ -42,24 +47,24 @@ private boolean evaluateCriterion(PostContingencyResult result, String criterion
             }
         };
     }
+
     private boolean evaluateNonConvergence(PostContingencyResult result) {
         boolean converged = result.getStatus() == PostContingencyComputationStatus.CONVERGED;
         if (!converged) {
-            LOGGER.debug("Non-convergence detected for contingency {}", 
-                result.getContingency().getId());
+            LOGGER.debug("Non-convergence detected for contingency {}", result.getContingency().getId());
         }
         return !converged;
     }
 
     private boolean evaluateLimitViolations(PostContingencyResult result) {
         boolean hasViolations = !result.getLimitViolationsResult().getLimitViolations().isEmpty();
         if (hasViolations) {
-            LOGGER.debug("Limit violations detected for contingency {}", 
-                result.getContingency().getId());
+            LOGGER.debug("Limit violations detected for contingency {}", result.getContingency().getId());
         }
         return hasViolations;
     }
+
     private boolean evaluateSpsTriggered(PostContingencyResult result) {
-        return false;
+        return true;
     }
 }

security-analysis/mixed-security-analysis/src/main/java/com/powsybl/mixed/security/analysis/criteria/SwitchDecision.java

@@ -26,8 +26,12 @@ public String getReason() {
 
     @Override
     public boolean equals(Object o) {
-        if (this == o) return true;
-        if (o == null || getClass() != o.getClass()) return false;
+        if (this == o) {
+            return true;
+        }
+        if (o == null || getClass() != o.getClass()) {
+            return false;
+        }
         SwitchDecision that = (SwitchDecision) o;
         return shouldSwitch == that.shouldSwitch && Objects.equals(reason, that.reason);
     }
@@ -40,9 +44,9 @@ public int hashCode() {
     @Override
     public String toString() {
         return "SwitchDecision{" +
-                "shouldSwitch=" + shouldSwitch +
-                ", reason='" + reason + '\'' +
-                '}';
+            "shouldSwitch=" + shouldSwitch +
+            ", reason='" + reason + '\'' +
+            '}';
     }
 }
 

security-analysis/mixed-security-analysis/src/main/java/com/powsybl/mixed/security/analysis/parameters/MixedModeParametersExtension.java

@@ -17,26 +17,19 @@ public class MixedModeParametersExtension extends AbstractExtension<SecurityAnal
     public static final String NAME = "mixed-mode-analysis";
     /**
      * The name of the static simulator to use for the first pass.
-     * For example: "load-flow"
      */
     private String staticSimulator;
 
     /**
      * The name of the dynamic simulator to use for the second pass (for complex cases).
-     * For example: "dynaflow"
      */
     private String dynamicSimulator;
 
     /**
      * The list of criteria that trigger a switch to the dynamic simulator.
-     * Possible values: "NON_CONVERGENCE", "SEVERITY_THRESHOLD".
      */
     private List<String> switchCriteria;
 
-    // --- Getters and Setters ---
-    // These are necessary so that configuration tools like Jackson (used by PowSybl)
-    // can populate the fields of this object.
-
     public String getStaticSimulator() {
         return staticSimulator;
     }

security-analysis/mixed-security-analysis/src/test/java/com/powsybl/mixed/security/analysis/MixedSecurityAnalysisProviderTest.java

@@ -13,6 +13,7 @@
 import static org.junit.jupiter.api.Assertions.*;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
+
 class MixedSecurityAnalysisProviderTest {
     @Mock
     private Network network;
@@ -21,21 +22,25 @@ class MixedSecurityAnalysisProviderTest {
     @Mock
     private SecurityAnalysisRunParameters runParameters;
     private MixedSecurityAnalysisProvider provider;
+
     @BeforeEach
     void setUp() {
         MockitoAnnotations.openMocks(this);
         provider = new MixedSecurityAnalysisProvider();
     }
+
     @Test
     void testProviderName() {
         assertEquals("MixedSecurityAnalysis", provider.getName());
     }
+
     @Test
     void testProviderVersion() {
         String version = provider.getVersion();
         assertNotNull(version);
         assertFalse(version.isEmpty());
     }
+
     @Test
     void testRunMissingExtensionThrows() {
         SecurityAnalysisParameters mockSaParams = mock(SecurityAnalysisParameters.class);