remove a code smell

So-Fras · flo-dup · commit 71412764e257 · 2023-06-07T22:04:05.000+02:00
Signed-off-by: Sophie Frasnedo &lt;sophie.frasnedo@rte-france.com&gt;
diff --git a/single-line-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/styles/AbstractStyleProvider.java b/single-line-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/styles/AbstractStyleProvider.java
@@ -51,10 +51,8 @@ public List<String> getNodeStyles(VoltageLevelGraph graph, Node node, ComponentL
             styles.add(StyleClassConstants.FICTITIOUS_NODE_STYLE_CLASS);
         }
 
-        if (node instanceof BusConnection) {
-            if (node.isDisconnected()) {
-                styles.add(StyleClassConstants.DISCONNECTED_BUS_CONNECTION_STYLE_CLASS);
-            }
+        if (node instanceof BusConnection && node.isDisconnected()) {
+            styles.add(StyleClassConstants.DISCONNECTED_BUS_CONNECTION_STYLE_CLASS);
         }
 
         return styles;

Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,8 @@ public List<String> getNodeStyles(VoltageLevelGraph graph, Node node, ComponentL`
`51`	`51`	`styles.add(StyleClassConstants.FICTITIOUS_NODE_STYLE_CLASS);`
`52`	`52`	`}`
`53`	`53`
`54`		`- if (node instanceof BusConnection) {`
`55`		`- if (node.isDisconnected()) {`
`56`		`- styles.add(StyleClassConstants.DISCONNECTED_BUS_CONNECTION_STYLE_CLASS);`
`57`		`- }`
	`54`	`+ if (node instanceof BusConnection && node.isDisconnected()) {`
	`55`	`+ styles.add(StyleClassConstants.DISCONNECTED_BUS_CONNECTION_STYLE_CLASS);`
`58`	`56`	`}`
`59`	`57`
`60`	`58`	`return styles;`