Skip to content

Commit ae2f39f

Browse files
Remove marker interface ForceParameter
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
1 parent c7802de commit ae2f39f

13 files changed

Lines changed: 105 additions & 28 deletions

File tree

diagram-util/src/main/java/com/powsybl/diagram/util/forcelayout/forces/AbstractForce.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,13 @@
88

99
package com.powsybl.diagram.util.forcelayout.forces;
1010

11-
import com.powsybl.diagram.util.forcelayout.forces.forceparameter.ForceParameter;
1211
import com.powsybl.diagram.util.forcelayout.geometry.ForceGraph;
1312
import com.powsybl.diagram.util.forcelayout.geometry.Point;
1413
import com.powsybl.diagram.util.forcelayout.geometry.Vector2D;
1514

1615
/**
1716
* @author Nathan Dissoubray {@literal <nathan.dissoubray at rte-france.com>}
1817
*/
19-
public abstract class AbstractForce<V, E, P extends ForceParameter> {
20-
P forceParameter;
21-
22-
AbstractForce(P forceParameter) {
23-
this.forceParameter = forceParameter;
24-
}
25-
26-
public void setForceParameter(P forceParameter) {
27-
this.forceParameter = forceParameter;
28-
}
29-
18+
public abstract class AbstractForce<V, E> {
3019
public abstract Vector2D calculateForce(V forThisVertex, Point correspondingPoint, ForceGraph<V, E> forceGraph);
3120
}

diagram-util/src/main/java/com/powsybl/diagram/util/forcelayout/forces/CoulombForce.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@
1616
/**
1717
* @author Nathan Dissoubray {@literal <nathan.dissoubray at rte-france.com>}
1818
*/
19-
public class CoulombForce<V, E> extends AbstractForce<V, E, IntensityEffectFromFixedNodesParameters> {
19+
public class CoulombForce<V, E> extends AbstractForce<V, E> {
20+
21+
private final IntensityEffectFromFixedNodesParameters forceParameter;
2022

2123
public CoulombForce(IntensityEffectFromFixedNodesParameters forceParameter) {
22-
super(forceParameter);
24+
this.forceParameter = forceParameter;
2325
}
2426

2527
@Override

diagram-util/src/main/java/com/powsybl/diagram/util/forcelayout/forces/GravityForceByEdgeNumber.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@
1616
/**
1717
* @author Nathan Dissoubray {@literal <nathan.dissoubray at rte-france.com>}
1818
*/
19-
public class GravityForceByEdgeNumber<V, E> extends AbstractForce<V, E, IntensityParameter> {
19+
public class GravityForceByEdgeNumber<V, E> extends AbstractForce<V, E> {
20+
21+
private final IntensityParameter forceParameter;
2022

2123
public GravityForceByEdgeNumber(IntensityParameter forceParameter) {
22-
super(forceParameter);
24+
this.forceParameter = forceParameter;
2325
}
2426

2527
@Override

diagram-util/src/main/java/com/powsybl/diagram/util/forcelayout/forces/GravityForceLinear.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,11 @@
1616
/**
1717
* @author Nathan Dissoubray {@literal <nathan.dissoubray at rte-france.com>}
1818
*/
19-
public class GravityForceLinear<V, E> extends AbstractForce<V, E, IntensityParameter> {
19+
public class GravityForceLinear<V, E> extends AbstractForce<V, E> {
20+
private final IntensityParameter forceParameter;
2021

2122
public GravityForceLinear(IntensityParameter forceParameter) {
22-
super(forceParameter);
23+
this.forceParameter = forceParameter;
2324
}
2425

2526
@Override

diagram-util/src/main/java/com/powsybl/diagram/util/forcelayout/forces/GravityForceUnit.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,11 @@
1515
/**
1616
* @author Nathan Dissoubray {@literal <nathan.dissoubray at rte-france.com>}
1717
*/
18-
public class GravityForceUnit<V, E> extends AbstractForce<V, E, IntensityParameter> {
18+
public class GravityForceUnit<V, E> extends AbstractForce<V, E> {
19+
private final IntensityParameter forceParameter;
1920

2021
public GravityForceUnit(IntensityParameter forceParameter) {
21-
super(forceParameter);
22+
this.forceParameter = forceParameter;
2223
}
2324

2425
@Override

diagram-util/src/main/java/com/powsybl/diagram/util/forcelayout/forces/SpringForce.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,11 @@
1919
/**
2020
* @author Nathan Dissoubray {@literal <nathan.dissoubray at rte-france.com>}
2121
*/
22-
public class SpringForce<V, E> extends AbstractForce<V, E, SpringContainer<DefaultEdge>> {
22+
public class SpringForce<V, E> extends AbstractForce<V, E> {
23+
private final SpringContainer<DefaultEdge> forceParameter;
2324

2425
public SpringForce(SpringContainer<DefaultEdge> forceParameter) {
25-
super(forceParameter);
26+
this.forceParameter = forceParameter;
2627
}
2728

2829
/// This is Hooke's Law

diagram-util/src/main/java/com/powsybl/diagram/util/forcelayout/forces/forceparameter/IntensityParameter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
/**
1111
* @author Nathan Dissoubray {@literal <nathan.dissoubray at rte-france.com>}
1212
*/
13-
public class IntensityParameter implements ForceParameter {
13+
public class IntensityParameter {
1414
private double forceIntensity;
1515

1616
public IntensityParameter(double forceIntensity) {

diagram-util/src/main/java/com/powsybl/diagram/util/forcelayout/forces/forceparameter/SpringContainer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
/**
1515
* @author Nathan Dissoubray {@literal <nathan.dissoubray at rte-france.com>}
1616
*/
17-
public class SpringContainer<E> implements ForceParameter {
17+
public class SpringContainer<E> {
1818
private final Map<E, SpringParameter> springs;
1919

2020
public SpringContainer() {

diagram-util/src/main/java/com/powsybl/diagram/util/forcelayout/forces/forceparameter/SpringParameter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
/**
1111
* @author Nathan Dissoubray {@literal <nathan.dissoubray at rte-france.com>}
1212
*/
13-
public class SpringParameter implements ForceParameter {
13+
public class SpringParameter {
1414
private double stiffness;
1515
private double length;
1616

diagram-util/src/main/java/com/powsybl/diagram/util/forcelayout/layouts/AbstractLayoutAlgorithm.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@
1919
* @author Nathan Dissoubray {@literal <nathan.dissoubray at rte-france.com>}
2020
*/
2121
public abstract class AbstractLayoutAlgorithm<V, E> {
22-
protected List<AbstractForce<V, E, ? extends ForceParameter>> forces;
22+
protected List<AbstractForce<V, E>> forces;
2323

2424
public abstract void calculateLayout(ForceGraph<V, E> forceGraph);
2525

26-
AbstractLayoutAlgorithm(List<AbstractForce<V, E, ? extends ForceParameter>> forces) {
26+
AbstractLayoutAlgorithm(List<AbstractForce<V, E>> forces) {
2727
this.forces = forces;
2828
}
2929

0 commit comments

Comments
 (0)