Skip to content

Commit 7207d40

Browse files
armic-artelysmarifunf
authored andcommitted
PR #55 - Replace explicit line-break characters replacement by generic calls to TestUtil#normalizeLineSeparator
Signed-off-by: marifunf <[email protected]>
1 parent 1b68d71 commit 7207d40

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

metrix-mapping/src/test/java/com/powsybl/metrix/mapping/TimeSeriesDslLoaderTest.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
package com.powsybl.metrix.mapping;
1010

1111
import com.google.common.collect.Sets;
12+
import com.powsybl.commons.TestUtil;
1213
import com.powsybl.commons.io.table.TableFormatterConfig;
1314
import com.powsybl.iidm.network.Network;
1415
import com.powsybl.timeseries.*;
@@ -268,8 +269,7 @@ void tsStatsFunctions() throws IOException {
268269
csvWriter.printMappingSynthesis(System.out, new TableFormatterConfig());
269270
}
270271

271-
String output = outputStream.toString();
272-
output = output.replaceAll("\r\n", "\n");
272+
String output = TestUtil.normalizeLineSeparator(outputStream.toString());
273273
assertEquals("1.0\n0.2\n-5.0\n3.0\n1.0\n", output);
274274

275275
outputStream.reset();
@@ -279,8 +279,7 @@ void tsStatsFunctions() throws IOException {
279279
csvWriter.printMappingSynthesis(System.out, new TableFormatterConfig());
280280
}
281281

282-
output = outputStream.toString();
283-
output = output.replaceAll("\r\n", "\n");
282+
output = TestUtil.normalizeLineSeparator(outputStream.toString());
284283
assertEquals("6.0\n2.0\n1.0\n3.0\n2.0\n", output);
285284
}
286285

metrix-mapping/src/test/java/com/powsybl/metrix/mapping/TimeSeriesMapperCheckerTest.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
import com.google.common.collect.ImmutableList;
1212
import com.google.common.collect.Range;
13+
import com.powsybl.commons.TestUtil;
1314
import com.powsybl.commons.datasource.MemDataSource;
1415
import com.powsybl.iidm.network.Generator;
1516
import com.powsybl.iidm.network.HvdcLine;
@@ -306,7 +307,7 @@ private void compareLogger(TimeSeriesMappingLogger logger, String expectedType,
306307
try (BufferedWriter bufferedWriter = new BufferedWriter(loggerCsvOutput)) {
307308
logger.writeCsv(bufferedWriter);
308309
bufferedWriter.flush();
309-
String loggerCsv = loggerCsvOutput.toString().replaceAll("\r\n", "\n");
310+
String loggerCsv = TestUtil.normalizeLineSeparator(loggerCsvOutput.toString());
310311
String[] lines = loggerCsv.split("\n");
311312
int nbLines = lines.length;
312313
int nbExpectedLines = 1;

metrix-mapping/src/test/java/com/powsybl/metrix/mapping/TimeSeriesProvideTsTest.java metrix-mapping/src/test/java/com/powsybl/metrix/mapping/TimeSeriesProviderTsTest.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
package com.powsybl.metrix.mapping;
1010

1111
import com.google.common.collect.ImmutableSet;
12+
import com.powsybl.commons.TestUtil;
1213
import com.powsybl.iidm.network.Network;
1314
import com.powsybl.iidm.xml.NetworkXml;
1415
import com.powsybl.timeseries.*;
@@ -22,7 +23,7 @@
2223

2324
import static org.junit.jupiter.api.Assertions.assertEquals;
2425

25-
class TimeSeriesProvideTsTest {
26+
class TimeSeriesProviderTsTest {
2627

2728
private Network network;
2829

@@ -241,7 +242,7 @@ void provideTsNotMappedTest() throws Exception {
241242
try (StringWriter sw = new StringWriter()) {
242243
TimeSeriesMappingConfig mappingConfig = dsl.load(network, mappingParameters, store, sw, null);
243244
assertEquals(ImmutableSet.of(new MappingKey(EquipmentVariable.targetP, "FSSV.O11_G")), mappingConfig.getGeneratorTimeSeries());
244-
assertEquals("WARNING;Mapping script;provideTs - Time series can not be provided for id FSSV.O11_G because id is not mapped on targetP\n", sw.toString().replace("\r\n", "\n"));
245+
assertEquals("WARNING;Mapping script;provideTs - Time series can not be provided for id FSSV.O11_G because id is not mapped on targetP\n", TestUtil.normalizeLineSeparator(sw.toString()));
245246
}
246247
}
247248

@@ -265,7 +266,7 @@ void provideTsEmptyFilterTest() throws Exception {
265266
try (StringWriter sw = new StringWriter()) {
266267
TimeSeriesMappingConfig mappingConfig = dsl.load(network, mappingParameters, store, sw, null);
267268
assertEquals(Collections.emptySet(), mappingConfig.getGeneratorTimeSeries());
268-
assertEquals("WARNING;Mapping script;provideTs - Empty filtered list for equipment type GENERATOR and variables [targetP]\n", sw.toString().replaceAll("\r\n", "\n"));
269+
assertEquals("WARNING;Mapping script;provideTs - Empty filtered list for equipment type GENERATOR and variables [targetP]\n", TestUtil.normalizeLineSeparator(sw.toString()));
269270
}
270271
}
271272
}

0 commit comments

Comments
 (0)