Fix failure detection in snapshot CI (#197)

* fix failure detection in snapshot ci

Signed-off-by: Nicolas Rol <[email protected]>

* delete test on PR

Signed-off-by: Nicolas Rol <[email protected]>

---------

Signed-off-by: Nicolas Rol <[email protected]>

Author: rolnico

Diff for: .github/workflows/snapshot-ci.yml

@@ -172,17 +172,6 @@ jobs:
     runs-on: ubuntu-latest
     if: always()
     steps:
-      - name: Determine workflow status
-        id: workflow_status
-        run: |
-          if [ "${{ job.status }}" == "success" ]; then
-            echo "icon=✅" >> $GITHUB_OUTPUT
-            echo "status=Successful" >> $GITHUB_OUTPUT
-          else
-            echo "icon=❌" >> $GITHUB_OUTPUT
-            echo "status=Failed" >> $GITHUB_OUTPUT
-          fi
-
       - name: Download job results
         uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
 
@@ -192,6 +181,17 @@ jobs:
             cat "$dir"/* >> combined_job_results.txt
           done
 
+      - name: Determine workflow status
+        id: workflow_status
+        run: |
+          if grep -q "failure" combined_job_results.txt; then
+            echo "icon=❌" >> $GITHUB_OUTPUT
+            echo "status=Failed" >> $GITHUB_OUTPUT
+          else
+            echo "icon=✅" >> $GITHUB_OUTPUT
+            echo "status=Successful" >> $GITHUB_OUTPUT
+          fi
+
       - name: Format job results
         id: format_results
         run: |