more dead code removed. And some Sonar phobia changed

Author: vidaldid-rte

src/main/java/com/powsybl/openloadflow/ac/outerloop/HvdcWarmStartOuterloop.java

@@ -17,9 +17,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.HashMap;
 import java.util.List;
-import java.util.Map;
 
 /**
  * @author Didier Vidal {@literal <didier.vidal_externe at rte-france.com>}
@@ -28,7 +26,6 @@ public class HvdcWarmStartOuterloop implements AcOuterLoop {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(HvdcWarmStartOuterloop.class);
 
-    private static final int MAX_STEPS = 10;
     public static final String NAME = "HvdcWarmStart";
 
     private enum Step {
@@ -39,11 +36,6 @@ private enum Step {
     private static final class ContextData {
 
         private Step step = Step.UNFREEZE;
-        private final Map<String, Boolean> angleSign = new HashMap<>();
-
-    }
-
-    public HvdcWarmStartOuterloop() {
 
     }
 
@@ -69,8 +61,6 @@ public OuterLoopResult check(AcOuterLoopContext context, ReportNode reportNode)
 
     private OuterLoopResult unfreezeHvdcs(AcOuterLoopContext context, ReportNode reportNode) {
 
-        ContextData contextData = (ContextData) context.getData();
-
         List<LfHvdc> frozenHvdc = context.getNetwork().getHvdcs().stream()
                 .filter(LfHvdc::isAcEmulation)
                 .filter(LfHvdc::isFrozen)

src/main/java/com/powsybl/openloadflow/network/impl/LfHvdcImpl.java

@@ -198,16 +198,11 @@ public double getPMaxFromCS2toCS1() {
     @Override
     public double freezeFromCurrentAngles() {
         double p1Val = Double.NaN;
-        double p2Val = Double.NaN;
-        if (p1 instanceof AbstractHvdcAcEmulationFlowEquationTerm pAcEmu) {
-            if (pAcEmu.isActive()) {
-                p1Val = pAcEmu.freezeFromCurrentAngles();
-            }
+        if (p1 instanceof AbstractHvdcAcEmulationFlowEquationTerm pAcEmu && pAcEmu.isActive()) {
+            p1Val = pAcEmu.freezeFromCurrentAngles();
         }
-        if (p2 instanceof AbstractHvdcAcEmulationFlowEquationTerm pAcEmu) {
-            if (pAcEmu.isActive()) {
-                p2Val = pAcEmu.freezeFromCurrentAngles();
-            }
+        if (p2 instanceof AbstractHvdcAcEmulationFlowEquationTerm pAcEmu && pAcEmu.isActive()) {
+            pAcEmu.freezeFromCurrentAngles();
         }
         return p1Val;
     }