fix sonar

Signed-off-by: Godelaine de Montmorillon <godelaine.demontmorillon@rte-france.com>

Author: Godelaine

data/crac/crac-io/crac-io-cim/src/main/java/com/powsybl/openrao/data/crac/io/cim/craccreator/RemedialActionSeriesCreator.java

@@ -96,15 +96,11 @@ public void createAndAddRemedialActionSeries() {
                 }
             });
 
-            if (contingencies.isEmpty() && !invalidContingencies.isEmpty()) {
-                cimSerie.getRemedialActionSeries().forEach(remedialActionSeries -> this.remedialActionSeriesCreationContexts.add(RemedialActionSeriesCreationContext.notImported(remedialActionSeries.getMRID(), ImportStatus.INCONSISTENCY_IN_DATA, String.format("This RA is not imported because it is only associated to invalid contingencies %s", invalidContingencies))));
-                continue;
-            }
-
             // Read and store Monitored Series
             this.cnecs = getFlowCnecsFromMonitoredAndContingencySeries(cimSerie);
+
             // Read and store AdditionalConstraint Series
-            if (!readAdditionalConstraintSeries(cimSerie)) {
+            if (doNotImportRaSeries(cimSerie)) {
                 continue;
             }
             // Read and create / modify RA creators
@@ -124,6 +120,12 @@ public void createAndAddRemedialActionSeries() {
         this.cracCreationContext.setRemedialActionSeriesCreationContexts(remedialActionSeriesCreationContexts);
     }
 
+    private boolean doNotImportRaSeries(Series cimSerie) {
+        // Do not import a series with only ill-defined contingencies
+        // Do not import a series with an ill-defined additional constraint series
+        return contingencies.isEmpty() && !invalidContingencies.isEmpty() || !readAdditionalConstraintSeries(cimSerie);
+    }
+
     /**
      * Reads AdditionalConstraint_Series of a Series and potentially creates associated angleCnec
      * If an angle cnec has been correctly defined, return true to import cimSerie's remedial actions.