changes after review

Signed-off-by: EDWARDS Philippe <edwardsphi@gm0winl1028.bureau.si.interne>

Author: EDWARDS Philippe

data/crac/crac-io/crac-io-json/src/main/java/com/powsybl/openrao/data/crac/io/json/serializers/StandardRangeSerializer.java

@@ -9,7 +9,6 @@
 
 import com.fasterxml.jackson.core.JsonGenerator;
 import com.fasterxml.jackson.databind.SerializerProvider;
-import com.powsybl.openrao.data.crac.api.range.RangeType;
 import com.powsybl.openrao.data.crac.api.range.StandardRange;
 import com.powsybl.openrao.data.crac.io.json.JsonSerializationConstants;
 
@@ -28,9 +27,7 @@ public void serialize(StandardRange value, JsonGenerator gen, SerializerProvider
         if (value.getMax() < Integer.MAX_VALUE) {
             gen.writeNumberField(JsonSerializationConstants.MAX, value.getMax());
         }
-        if (value.getRangeType() != RangeType.ABSOLUTE) {
-            gen.writeStringField(JsonSerializationConstants.RANGE_TYPE, JsonSerializationConstants.serializeRangeType(value.getRangeType()));
-        }
+        gen.writeStringField(JsonSerializationConstants.RANGE_TYPE, JsonSerializationConstants.serializeRangeType(value.getRangeType()));
         gen.writeEndObject();
     }
 }

data/crac/crac-io/crac-io-json/src/main/resources/schemas/counter-trade-range-action/counter-trade-range-action-v2.10.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json-schema.org/draft/2020-12/schema#",
-  "$id": "resource:/schemas/counter-trade-range-action/counter-trade-range-action-v2.8.json",
+  "$id": "resource:/schemas/counter-trade-range-action/counter-trade-range-action-v2.10.json",
   "type": "object",
   "properties": {
     "id": {
@@ -42,6 +42,9 @@
       "items": {
         "type": "object",
         "properties": {
+          "rangeType": {
+            "$ref": "../range-type/range-type-v2.3.json"
+          },
           "max": {
             "type": "number"
           },

data/crac/crac-io/crac-io-json/src/main/resources/schemas/counter-trade-range-action/counter-trade-range-action-v2.8.json

@@ -42,9 +42,6 @@
       "items": {
         "type": "object",
         "properties": {
-          "rangeType": {
-            "$ref": "../range-type/range-type-v2.3.json"
-          },
           "max": {
             "type": "number"
           },

data/crac/crac-io/crac-io-json/src/main/resources/schemas/hvdc-range-action/hvdc-range-action-v2.10.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json-schema.org/draft/2020-12/schema#",
-  "$id": "resource:/schemas/hvdc-range-action/hvdc-range-action-v2.8.json",
+  "$id": "resource:/schemas/hvdc-range-action/hvdc-range-action-v2.10.json",
   "type": "object",
   "properties": {
     "id": {

data/crac/crac-io/crac-io-json/src/main/resources/schemas/injection-range-action/injection-range-action-v2.10.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json-schema.org/draft/2020-12/schema#",
-  "$id": "resource:/schemas/injection-range-action/injection-range-action-v2.8.json",
+  "$id": "resource:/schemas/injection-range-action/injection-range-action-v2.10.json",
   "type": "object",
   "properties": {
     "id": {

data/crac/crac-io/crac-io-json/src/test/java/com/powsybl/openrao/data/crac/io/json/JsonRetrocompatibilityTest.java

@@ -426,8 +426,10 @@ void importV2Point10WithMaxTso() throws IOException {
         String cracFilePath = "/crac2.10-with_maxtso.json";
         InputStream cracFile = getClass().getResourceAsStream(cracFilePath);
 
-        Crac crac = Crac.read(cracFilePath, cracFile, network);
-        assertEquals(1, crac.getFlowCnecs().size());
+        OpenRaoException exception = assertThrows(OpenRaoException.class, () -> Crac.read(cracFilePath, cracFile, network));
+        assertEquals("JSON file is not a valid CRAC v2.10. Reasons: /ra-usage-limits-per-instant/0: " +
+                         "property 'max-tso' is not defined in the schema and the schema does not allow additional properties",
+                     exception.getMessage());
     }
 
     private void testContentOfV1Point0Crac(Crac crac) {

data/crac/crac-io/crac-io-json/src/test/resources/crac2.10-with_maxtso.json

@@ -1,6 +1,6 @@
 {
   "type": "CRAC",
-  "version": "2.8",
+  "version": "2.10",
   "info": "Generated by PowSyBl OpenRAO https://powsybl.readthedocs.io/projects/openrao/",
   "id": "bad-crac",
   "name": "bad-crac",