Skip to content

Commit b97fdc1

Browse files
committed
fix after com
Signed-off-by: CHEN Roxane <roxane.chen@rte-france.com>
1 parent 0130d77 commit b97fdc1

2 files changed

Lines changed: 19 additions & 7 deletions

File tree

tests/src/test/resources/com/powsybl/openrao/tests/features/4_time_coupled/4_2_generator_constraints_json_1.feature

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -412,8 +412,9 @@ Feature: 4.2: Time-coupled generator constraints with MARMOT based on JSON time-
412412
Then the preventive power of load "FFR1AA1 _load" at timestamp "2025-11-04 23:30" is 0.0 MW
413413

414414
Scenario: 4.2.4: Long lead and lag times and no gradient
415-
The generator has a long lead time (6h), since the generator is initially OFF ie. if it had enough time to warm up to be turn on at 4:00.
416-
For now, we assume that the answer is yes. We can set it at its optimal power at 4:00 even if the lead time is 6h.
415+
The generator has a long lead time (6h) but it is initially OFF.
416+
Meaning that we can't really know when it was last shut down so we don't know if it had enough time to warm up to be turned on at 4:00.
417+
For now, we assume that the answer is yes: we can start it at 4:00 even if the lead time is 6h since it was initially OFF.
417418
Given configuration file is "epic93/RaoParameters_minCost_megawatt_dc_0_shift.json"
418419
Given time-coupled constraints are in file "epic93/time-coupled-constraints-with-long-lead-and-long-lag-times.json" and rao inputs are:
419420
| Timestamp | Network | CRAC |
@@ -541,7 +542,7 @@ Feature: 4.2: Time-coupled generator constraints with MARMOT based on JSON time-
541542

542543
Scenario: 4.2.5: Small upward gradient < PMin and Pmin - downward gradient * 1h = PMax
543544
We have a small upward gradient more precisely the gradient < PMin, meaning that if we took it into account between [0;PMin] we should
544-
not be able to reach the PMin in just one timestamp. However, one of our convention dictate that the gradient only matter above PMin !
545+
not be able to reach the PMin in just one timestamp. However, one of our convention dictates that the gradient only matter above PMin !
545546
At start up the generator can reach up to PMin + gradient * delta_t.
546547
Similarly, the generator can be shut down in one timestamp if P <= Pmin - downward gradient * delta_t which is the case in this test.
547548
Given configuration file is "epic93/RaoParameters_minCost_megawatt_dc_0_shift.json"
@@ -812,7 +813,7 @@ Feature: 4.2: Time-coupled generator constraints with MARMOT based on JSON time-
812813
In particular, the generator does not go through PMin during its startup and shutdown -> we should not force it as it is not optimal.
813814
Since there is no gradient constraint, it should be able to reach optimal power after waiting for sufficient time (satisfying the lead and lag time constraints).
814815
Given configuration file is "epic93/RaoParameters_minCost_megawatt_dc_0_shift_penalty_100.json"
815-
Given time-coupled constraints are in file "epic93/empty-time-coupled-constraints.json" and rao inputs are:
816+
Given time-coupled constraints are in file "epic93/time-coupled-constraints-with-lead-and-lag-times-4_2_7.json" and rao inputs are:
816817
| Timestamp | Network | CRAC |
817818
| 2025-11-04 00:30 | epic93/6Nodes_targetP_1500.xiidm | epic93/us93_3_6/crac_202511040030.json |
818819
| 2025-11-04 01:30 | epic93/6Nodes_targetP_1500.xiidm | epic93/us93_3_6/crac_202511040130.json |
@@ -1070,9 +1071,9 @@ Feature: 4.2: Time-coupled generator constraints with MARMOT based on JSON time-
10701071
Then the total cost for all timestamps is 1750140.0
10711072

10721073
Scenario: 4.2.9: Same as 4.2.8, with gradient
1073-
The same issue due to the long lead and lag time + we have a downward and upward gradient.
1074-
At 3h30 it needs to start stepping down to 2900 MW (Pmin - downward gradient * 1h = 2900 MW) so that can be shut down at 4h30-> 100 MW of overload
1075-
Same the generator step up to 2900 MW at 20h30 to reach the max at 21h30.
1074+
The same issue as 4.2.8 due to the long lead and lag time + we have a downward and upward gradient.
1075+
At 3h30 it needs to start stepping down to 2900 MW (Pmin - downward gradient * 1h = 2900 MW) so that it can be shut down at 4h30-> 100 MW of overload
1076+
Same the generator steps up to 2900 MW at 20h30 to reach the max at 21h30.
10761077
Given configuration file is "epic93/RaoParameters_minCost_megawatt_dc_0_shift_penalty_100.json"
10771078
Given time-coupled constraints are in file "epic93/time-coupled-constraints-with-lead-and-lag-times-and-gradients.json" and rao inputs are:
10781079
| Timestamp | Network | CRAC |
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
{
2+
"type": "OpenRAO Time-Coupled Constraints",
3+
"version": "1.0",
4+
"generatorConstraints": [
5+
{
6+
"generatorId": "BBE1AA1 _generator",
7+
"leadTime": 1.25,
8+
"lagTime": 2.5
9+
}
10+
]
11+
}

0 commit comments

Comments
 (0)