fix: changeFields parsing

Author: pozil

package.json

@@ -1,6 +1,6 @@
 {
     "name": "salesforce-pubsub-api-client",
-    "version": "2.4.0",
+    "version": "2.4.1",
     "type": "module",
     "description": "A node client for the Salesforce Pub/Sub API",
     "author": "pozil",
@@ -22,21 +22,21 @@
         "prepublishOnly": "npm run build"
     },
     "dependencies": {
-        "@grpc/grpc-js": "^1.8.7",
-        "@grpc/proto-loader": "^0.7.4",
+        "@grpc/grpc-js": "^1.8.11",
+        "@grpc/proto-loader": "^0.7.5",
         "avro-js": "^1.11.1",
         "certifi": "^14.5.15",
         "dotenv": "^16.0.3",
         "jsforce": "^1.11.0",
-        "undici": "^5.16.0"
+        "undici": "^5.20.0"
     },
     "devDependencies": {
         "@chialab/esbuild-plugin-meta-url": "^0.17.2",
-        "eslint": "^8.33.0",
+        "eslint": "^8.35.0",
         "husky": "^8.0.3",
-        "lint-staged": "^13.1.0",
-        "prettier": "^2.8.1",
-        "tsup": "^6.5.0",
+        "lint-staged": "^13.1.2",
+        "prettier": "^2.8.4",
+        "tsup": "^6.6.3",
         "typescript": "^4.9.5"
     },
     "lint-staged": {

src/eventParser.js

@@ -47,20 +47,23 @@ function parseFieldBitmaps(allFields, fieldBitmapsAsHex) {
     if (fieldBitmapsAsHex.length === 0) {
         return [];
     }
+
     let fieldNames = [];
     // Replace top field level bitmap with list of fields
     if (fieldBitmapsAsHex[0].startsWith('0x')) {
-        fieldNames = fieldNames.concat(
-            getFieldNamesFromBitmap(allFields, fieldBitmapsAsHex[0])
-        );
+        fieldNames = getFieldNamesFromBitmap(allFields, fieldBitmapsAsHex[0]);
     }
     // Process compound fields
-    if (fieldBitmapsAsHex[fieldBitmapsAsHex.length - 1].indexOf('-') !== -1) {
+    if (
+        fieldBitmapsAsHex.length > 1 &&
+        fieldBitmapsAsHex[fieldBitmapsAsHex.length - 1].indexOf('-') !== -1
+    ) {
         fieldBitmapsAsHex.forEach((fieldBitmapAsHex) => {
             const bitmapMapStrings = fieldBitmapAsHex.split('-');
             // Ignore top level field bitmap
             if (bitmapMapStrings.length >= 2) {
-                const parentField = allFields[parseInt(bitmapMapStrings[0])];
+                const parentField =
+                    allFields[parseInt(bitmapMapStrings[0], 10)];
                 const childFields = getChildFields(parentField);
                 const childFieldNames = getFieldNamesFromBitmap(
                     childFields,
@@ -83,8 +86,6 @@ function getChildFields(parentField) {
     types.forEach((type) => {
         if (type instanceof avro.types.RecordType) {
             fields = fields.concat(type.getFields());
-        } else if (type instanceof avro.types.NullType) {
-            fields.push(null);
         }
     });
     return fields;
@@ -94,10 +95,12 @@ function getChildFields(parentField) {
  * Loads field names from a bitmap
  * @param {Field[]} fields list of Avro Field
  * @param {string} fieldBitmapAsHex
+ * @returns {string[]} field names
  */
 function getFieldNamesFromBitmap(fields, fieldBitmapAsHex) {
+    // Convert hex to binary and reverse bits
     let binValue = hexToBin(fieldBitmapAsHex);
-    binValue = reverseBytes(binValue); // Reverse byte order to match expected format
+    binValue = binValue.split('').reverse().join('');
     // Use bitmap to figure out field names based on index
     const fieldNames = [];
     for (let i = 0; i < binValue.length && i < fields.length; i++) {
@@ -108,14 +111,6 @@ function getFieldNamesFromBitmap(fields, fieldBitmapAsHex) {
     return fieldNames;
 }
 
-function reverseBytes(input) {
-    let output = '';
-    for (let i = input.length / 8 - 1; i >= 0; i--) {
-        output += input.substring(i * 8, (i + 1) * 8);
-    }
-    return output;
-}
-
 /**
  * Decodes the value of a replay ID from a buffer
  * @param {Buffer} encodedReplayId
@@ -139,7 +134,7 @@ export function encodeReplayId(replayId) {
 /**
  * Converts a hexadecimal string into a string binary representation
  * @param {string} hex
- * @returns
+ * @returns {string}
  */
 function hexToBin(hex) {
     let bin = hex.substring(2); // Remove 0x prefix