Skip to content

Commit 9b5d0cc

Browse files
committed
Address Copilot review round 3
- Add Multi-Arch: same to libcoraza-dev - Set explicit file modes in install (0644 for headers/static lib) - Run only C integration test, skip go test -race (not portable) - Add debian/* copyright stanza
1 parent a3db312 commit 9b5d0cc

3 files changed

Lines changed: 12 additions & 9 deletions

File tree

debian/control

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ Description: OWASP Coraza WAF C library - runtime
2727
Package: libcoraza-dev
2828
Section: libdevel
2929
Architecture: any
30+
Multi-Arch: same
3031
Depends: libcoraza1 (= ${binary:Version}), ${misc:Depends}
3132
Description: OWASP Coraza WAF C library - development files
3233
Coraza is an open-source Web Application Firewall engine. This package

debian/copyright

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ Files: *
77
Copyright: 2022-2026 OWASP Coraza contributors
88
License: Apache-2.0
99

10+
Files: debian/*
11+
Copyright: 2026 Pierre Pomes <pierre.pomes@gmail.com>
12+
License: Apache-2.0
13+
1014
License: Apache-2.0
1115
Licensed under the Apache License, Version 2.0 (the "License");
1216
you may not use this file except in compliance with the License.

debian/rules

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,11 @@ override_dh_auto_build:
2727

2828
override_dh_auto_install:
2929
# Install manually to decouple from the check target
30-
install -d debian/tmp/usr/lib
30+
install -d debian/tmp/$(MULTIARCH_LIBDIR)
3131
install -d debian/tmp/usr/include/coraza
32-
install libcoraza.a debian/tmp/usr/lib/
33-
install libcoraza.so debian/tmp/usr/lib/
34-
install coraza/coraza.h debian/tmp/usr/include/coraza/coraza.h
35-
# Upstream installs to /usr/lib; move to multiarch path
36-
mkdir -p debian/tmp/$(MULTIARCH_LIBDIR)
37-
mv debian/tmp/usr/lib/libcoraza.so debian/tmp/$(MULTIARCH_LIBDIR)/
38-
mv debian/tmp/usr/lib/libcoraza.a debian/tmp/$(MULTIARCH_LIBDIR)/
32+
install -m 0755 libcoraza.so debian/tmp/$(MULTIARCH_LIBDIR)/
33+
install -m 0644 libcoraza.a debian/tmp/$(MULTIARCH_LIBDIR)/
34+
install -m 0644 coraza/coraza.h debian/tmp/usr/include/coraza/coraza.h
3935
# Set SONAME and create versioned symlink chain
4036
patchelf --set-soname libcoraza.so.$(SOMAJOR) debian/tmp/$(MULTIARCH_LIBDIR)/libcoraza.so
4137
mv debian/tmp/$(MULTIARCH_LIBDIR)/libcoraza.so debian/tmp/$(MULTIARCH_LIBDIR)/libcoraza.so.$(SOVER)
@@ -44,7 +40,9 @@ override_dh_auto_install:
4440

4541
override_dh_auto_test:
4642
ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
47-
$(MAKE) check
43+
# Run only the C integration test; skip go test -race (not portable across archs)
44+
$(MAKE) tests/simple_get
45+
cd tests && ./check_result.sh simple_get
4846
endif
4947

5048
override_dh_dwz:

0 commit comments

Comments
 (0)