Skip to content

Commit c2758cb

Browse files
committed
fix examples: accept return code 1 (interrupted) from phase functions
1 parent 0d52c0c commit c2758cb

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

examples/java/SimpleGet.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,21 +102,21 @@ static void testLifecycle() throws IOException {
102102
ret = coraza.coraza_process_uri(tx, "/someurl?foo=bar", "GET", "HTTP/1.1");
103103
check(ret == 0, "coraza_process_uri failed: " + ret);
104104

105-
// coraza_process_request_headers
105+
// coraza_process_request_headers (returns 1 when interrupted by a deny rule)
106106
ret = coraza.coraza_process_request_headers(tx);
107-
check(ret == 0, "coraza_process_request_headers failed: " + ret);
107+
check(ret >= 0, "coraza_process_request_headers failed: " + ret);
108108

109109
// coraza_append_request_body (byte[] typemap: single array arg)
110110
ret = coraza.coraza_append_request_body(tx, "hello=world".getBytes());
111111
check(ret == 0, "coraza_append_request_body failed: " + ret);
112112

113113
// coraza_process_request_body
114114
ret = coraza.coraza_process_request_body(tx);
115-
check(ret == 0, "coraza_process_request_body failed: " + ret);
115+
check(ret >= 0, "coraza_process_request_body failed: " + ret);
116116

117117
// coraza_process_response_headers
118118
ret = coraza.coraza_process_response_headers(tx, 200, "HTTP/1.1");
119-
check(ret == 0, "coraza_process_response_headers failed: " + ret);
119+
check(ret >= 0, "coraza_process_response_headers failed: " + ret);
120120

121121
// coraza_add_response_header
122122
String cname = "Content-Type", cvalue = "text/plain";
@@ -130,7 +130,7 @@ static void testLifecycle() throws IOException {
130130

131131
// coraza_process_response_body
132132
ret = coraza.coraza_process_response_body(tx);
133-
check(ret == 0, "coraza_process_response_body failed: " + ret);
133+
check(ret >= 0, "coraza_process_response_body failed: " + ret);
134134

135135
// coraza_update_status_code
136136
coraza.coraza_update_status_code(tx, 200);

examples/python/simple_get.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,9 @@ def test_lifecycle():
108108
ret = _c.coraza_process_uri(tx, "/someurl?foo=bar", "GET", "HTTP/1.1")
109109
_check(ret == 0, f"coraza_process_uri failed: {ret}")
110110

111-
# coraza_process_request_headers
111+
# coraza_process_request_headers (returns 1 when interrupted by a deny rule)
112112
ret = _c.coraza_process_request_headers(tx)
113-
_check(ret == 0, f"coraza_process_request_headers failed: {ret}")
113+
_check(ret >= 0, f"coraza_process_request_headers failed: {ret}")
114114

115115
# coraza_append_request_body (bytes typemap: single argument)
116116
body = b"hello=world"
@@ -119,11 +119,11 @@ def test_lifecycle():
119119

120120
# coraza_process_request_body
121121
ret = _c.coraza_process_request_body(tx)
122-
_check(ret == 0, f"coraza_process_request_body failed: {ret}")
122+
_check(ret >= 0, f"coraza_process_request_body failed: {ret}")
123123

124124
# coraza_process_response_headers
125125
ret = _c.coraza_process_response_headers(tx, 200, "HTTP/1.1")
126-
_check(ret == 0, f"coraza_process_response_headers failed: {ret}")
126+
_check(ret >= 0, f"coraza_process_response_headers failed: {ret}")
127127

128128
# coraza_add_response_header
129129
cname, cvalue = "Content-Type", "text/plain"
@@ -139,7 +139,7 @@ def test_lifecycle():
139139

140140
# coraza_process_response_body
141141
ret = _c.coraza_process_response_body(tx)
142-
_check(ret == 0, f"coraza_process_response_body failed: {ret}")
142+
_check(ret >= 0, f"coraza_process_response_body failed: {ret}")
143143

144144
# coraza_update_status_code
145145
_c.coraza_update_status_code(tx, 200)

0 commit comments

Comments
 (0)