Skip to content

Commit ea4fb4c

Browse files
ppomesfzipi
authored andcommitted
address review: assert CORAZA_INTERRUPTION in examples, ignore coraza_free_string in SWIG
1 parent da57866 commit ea4fb4c

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

coraza.i

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
*/
2626
%ignore coraza_add_debug_log_callback;
2727
%ignore coraza_add_error_callback;
28+
%ignore coraza_free_string;
2829

2930
/*
3031
* Handle the char** output parameter for error messages.

examples/java/SimpleGet.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ static void testLifecycle() throws IOException {
102102
ret = coraza.coraza_process_uri(tx, "/someurl?foo=bar", "GET", "HTTP/1.1");
103103
check(ret == 0, "coraza_process_uri failed: " + ret);
104104

105-
// coraza_process_request_headers (returns 1 when interrupted by a deny rule)
105+
// coraza_process_request_headers (returns CORAZA_INTERRUPTION for the deny rule)
106106
ret = coraza.coraza_process_request_headers(tx);
107-
check(ret >= 0, "coraza_process_request_headers failed: " + ret);
107+
check(ret == 1, "coraza_process_request_headers: expected CORAZA_INTERRUPTION (1), got " + ret);
108108

109109
// coraza_append_request_body (byte[] typemap: single array arg)
110110
ret = coraza.coraza_append_request_body(tx, "hello=world".getBytes());

examples/python/simple_get.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,9 @@ def test_lifecycle():
108108
ret = _c.coraza_process_uri(tx, "/someurl?foo=bar", "GET", "HTTP/1.1")
109109
_check(ret == 0, f"coraza_process_uri failed: {ret}")
110110

111-
# coraza_process_request_headers (returns 1 when interrupted by a deny rule)
111+
# coraza_process_request_headers (returns CORAZA_INTERRUPTION for the deny rule)
112112
ret = _c.coraza_process_request_headers(tx)
113-
_check(ret >= 0, f"coraza_process_request_headers failed: {ret}")
113+
_check(ret == 1, f"coraza_process_request_headers: expected CORAZA_INTERRUPTION (1), got {ret}")
114114

115115
# coraza_append_request_body (bytes typemap: single argument)
116116
body = b"hello=world"

0 commit comments

Comments
 (0)