Skip to content

Commit 9b2d2b2

Browse files
committed
Remove ISample.Length
This has not been populated for a while and is not used osu! side. Rather than having an incorrectly zero value, let's remove it for now.
1 parent 451f8b2 commit 9b2d2b2

File tree

3 files changed

+0
-8
lines changed

3 files changed

+0
-8
lines changed

osu.Framework/Audio/Sample/ISample.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@ public interface ISample : IAdjustableAudioComponent
1515
/// </summary>
1616
string Name { get; }
1717

18-
/// <summary>
19-
/// The length in milliseconds of this <see cref="ISample"/>.
20-
/// </summary>
21-
double Length { get; }
22-
2318
/// <summary>
2419
/// The number of times this sample (as identified by name) can be played back concurrently.
2520
/// </summary>

osu.Framework/Audio/Sample/Sample.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ protected Sample(string name)
1919
Name = name;
2020
}
2121

22-
public double Length { get; protected set; }
2322
public Bindable<int> PlaybackConcurrency { get; } = new Bindable<int>(DEFAULT_CONCURRENCY);
2423

2524
internal Action<Sample> OnPlay;

osu.Framework/Graphics/Audio/DrawableSample.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@ public SampleChannel GetChannel()
5151

5252
string ISample.Name => sample.Name;
5353

54-
public double Length => sample.Length;
55-
5654
public Bindable<int> PlaybackConcurrency { get; } = new Bindable<int>(Sample.DEFAULT_CONCURRENCY);
5755

5856
private IAudioMixer? mixer;

0 commit comments

Comments
 (0)