Skip to content

Commit da1c2ec

Browse files
committed
Remove IsAlive from SampleChannel to let childern define their own
This commit also adds one for SampleChannelVirtual. It is needed to let childern use IsAlive from parent of SampleChannel.
1 parent 451f8b2 commit da1c2ec

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

osu.Framework/Audio/Sample/SampleChannel.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ protected override void UpdateState()
4444

4545
public virtual bool Looping { get; set; }
4646

47-
public override bool IsAlive => base.IsAlive && Playing;
48-
4947
public virtual ChannelAmplitudes CurrentAmplitudes { get; } = ChannelAmplitudes.Empty;
5048

5149
#region Mixing

osu.Framework/Audio/Sample/SampleChannelVirtual.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ internal class SampleChannelVirtual : SampleChannel
1313

1414
public override bool Playing => playing;
1515

16+
public override bool IsAlive => base.IsAlive && Playing;
17+
1618
public SampleChannelVirtual(string name)
1719
: base(name)
1820
{

0 commit comments

Comments
 (0)