Commit 6047fc0
authored
Allow using slider velocity control in toolbox to adjust velocity of selection (#38106)
https://github.com/user-attachments/assets/8d5f94b2-d7b6-4418-a8c2-2fb85aa77bb3
---
RFC
I have received information from @peppy that in the course of
preparations for the next lazer changelog video, @pishifat has expressed
dissatisfaction with the operation of the slider velocity control added
in #37746. If I understood correctly, the
issue was that the slider velocity control in question did not attempt
to interact with the current selection of objects. @peppy has requested
me to attempt to fix it before the next lazer release.
This PR contains an implementation of allowing the slider velocity
control to adjust the velocity of all selected sliders, if any.
I am not particularly happy with the resulting code for this feature,
but I also do not have many better ideas. Despite my attempts at
streamlining the logic after the initial pass, the implementation is
still tricky because it attempts to do much magic, both in trying to
achieve unobtrusive operation and sufficiently informative visual state.
There are subtle details that may turn out to be unsatisfactory to
mappers in practice. For one instance, the following flow may be of
concern:
1. Start with no selection. In this state the velocity control follows
the last slider by default.
2. Choose a velocity value manually.
3. Select an object.
4. Deselect the object.
5. The velocity value chosen in (2) is dropped.
Such behaviours can be brought back if desired, but at cost of further
additional complexity of the logic of the feature.1 parent 2e7628d commit 6047fc0
4 files changed
Lines changed: 221 additions & 78 deletions
File tree
- osu.Game.Rulesets.Osu.Tests/Editor
- osu.Game.Rulesets.Osu/Edit
- osu.Game/Graphics
- UserInterfaceV2
- UserInterface
Lines changed: 21 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
| |||
137 | 136 | | |
138 | 137 | | |
139 | 138 | | |
140 | | - | |
| 139 | + | |
141 | 140 | | |
142 | 141 | | |
143 | 142 | | |
144 | 143 | | |
145 | 144 | | |
146 | 145 | | |
147 | 146 | | |
148 | | - | |
| 147 | + | |
149 | 148 | | |
150 | 149 | | |
151 | 150 | | |
| |||
193 | 192 | | |
194 | 193 | | |
195 | 194 | | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
196 | 214 | | |
197 | 215 | | |
198 | 216 | | |
| |||
0 commit comments