Skip to content

Unstable Rate shouldn't be converted in osu!mania #30828

Closed as not planned
@peppy

Description

@peppy

Bumping to issue since it seems like something which needs resolution.

Discussed in #30698

Originally posted by KapiWilq November 17, 2024
A year ago, there was introduced a change in the way that the Unstable Rate is calculated. It made the Unstable Rate account for the gameplay rate, which made the Unstable Rate not require conversion when playing with rate-changing mods. There was raised a fair concern about osu!mania, but according to these replies the Unstable Rate value for osu!mania should be correct. It's not correct.

Why?

osu!mania scales hit windows to account for the rate change12. This makes the Unstable Rate not require conversion when playing with rate-changing mods since hit windows are being resized to make them "effectively" the same size as if you are playing without rate-changing mods. Therefore, by converting the Unstable Rate in osu!mania, it's value is incorrect. This also makes the Unstable Rate value shown in osu!(stable) correct.

osu!(stable) osu!(lazer)
screenshot352 osu_2024-11-16_18-15-38

This is the score that I used for the comparison in these screenshots: https://osu.ppy.sh/scores/mania/301846710

Footnotes

  1. https://github.com/ppy/osu/blob/master/osu.Game.Rulesets.Mania/Mods/IManiaRateAdjustmentMod.cs#L28

  2. https://github.com/ppy/osu/blob/master/osu.Game.Rulesets.Mania/Scoring/ManiaHitWindows.cs#L39-L45

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions