allowDynamicUpdate doesn't seems to be working from the demo project

[megasoft78]

Hi,
first of all, thank you very much for this amazing component.
I downloaded the repository to test the demo project but I don't think the allowDynamicUpdate is working.
The onScrollEnd doesn't seem to be fired.

Could you please help me?

Thank you in advance. :)

[prabhuignoto]

can you point me to the repo please to be able to replicate

[megasoft78]

https://github.com/prabhuignoto/react-chrono
branch master.
example Dynamic data load.

[dvd-z]

Dynamic load worked for me but I was getting a different issue with updating items in the demo: #135

[megasoft78]

Hi,
I found the problem:

Javascript is not 100% precise on the scroll with decimal values.

I solved replacing this code:
if (target.scrollHeight === scrolled) {
with this:
if ((target.scrollHeight - scrolled) < 1) {

Not sure is the best solution but it's working now. :)

[megasoft78]

Hi,
I quickly fork your project and made few changes for:

• Fix the scroll event issue
• Fix issue Dynamic load can fail to render all items provided #135
• Allow to provider url and make the card title a link

I hope can help. :)

[prabhuignoto]

@megasoft78 thanks, can you raise a PR for the change. i can take a look at it

[megasoft78]

@prabhuignoto Done.
Not sure I did it correctly. :)

[prabhuignoto]

@megasoft78 no issues i ll check it and make changes if needed. thanks for fixing this

[megasoft78]

@prabhuignoto No problem. 🙂
Thank you again for this amazing component. 😉