Updated minimum cmake requirement to be 3.19

prabhuomkar · prabhuomkar · commit e92e8e1aedeb · 2024-05-05T13:01:05.000+05:30
diff --git a/.github/workflows/build_macos.yml b/.github/workflows/build_macos.yml
@@ -29,7 +29,7 @@ jobs:
     - name: Set up CMake
       uses: jwlawson/actions-setup-cmake@v2
       with:
-        cmake-version: '3.14.0'
+        cmake-version: '3.19.0'
     - name: Set up Xcode
       uses: maxim-lobanov/setup-xcode@v1
       with:
diff --git a/.github/workflows/build_ubuntu.yml b/.github/workflows/build_ubuntu.yml
@@ -29,7 +29,7 @@ jobs:
     - name: Set up CMake
       uses: jwlawson/actions-setup-cmake@v2
       with:
-        cmake-version: '3.14.0'
+        cmake-version: '3.19.0'
     - name: Set up GCC
       uses: egor-tensin/setup-gcc@v1
       with:
diff --git a/.github/workflows/build_windows.yml b/.github/workflows/build_windows.yml
@@ -26,7 +26,7 @@ jobs:
         - {
             name: Windows MSVC 2019,
             os: windows-2019,
-            cmake: '3.14.0'
+            cmake: '3.19.0'
           }
         - {
             name: Windows MSVC 2022,
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(pytorch-cpp VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/README.md b/README.md
@@ -6,7 +6,7 @@
     <br />
 <img src="https://img.shields.io/github/license/prabhuomkar/pytorch-cpp">
 <img src="https://img.shields.io/badge/libtorch-2.3.0-ee4c2c">
-<img src="https://img.shields.io/badge/cmake-3.14-064f8d">
+<img src="https://img.shields.io/badge/cmake-3.19-064f8d">
 </p>
 
 
@@ -51,7 +51,7 @@ This repository provides tutorial code in C++ for deep learning researchers to l
 ## Requirements
 
 1. [C++-17](http://www.cplusplus.com/doc/tutorial/introduction/) compatible compiler
-2. [CMake](https://cmake.org/download/) (minimum version 3.14)
+2. [CMake](https://cmake.org/download/) (minimum version 3.19)
 3. [LibTorch version >= 1.12.0 and <= 2.3.0](https://pytorch.org/cppdocs/installing.html)
 4. [Conda](https://docs.conda.io/projects/conda/en/latest/user-guide/install/download.html)
 
diff --git a/cmake/check_files.cmake b/cmake/check_files.cmake
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 function(check_files BASE_DIR FILES_TO_CHECK FILE_MD5S MISSING_FILES)
     foreach(FILE_TO_CHECK ${${FILES_TO_CHECK}})
diff --git a/cmake/copy_torch_dlls.cmake b/cmake/copy_torch_dlls.cmake
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 function(copy_torch_dlls TARGET_NAME)
     # According to https://github.com/pytorch/pytorch/issues/25457
diff --git a/cmake/cpplint.cmake b/cmake/cpplint.cmake
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 find_program(CPPLINT cpplint)
 
diff --git a/cmake/create_torch_dll_hardlinks.cmake b/cmake/create_torch_dll_hardlinks.cmake
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 file(GLOB TORCH_DLLS "${TORCH_INSTALL_PREFIX}/lib/*.dll")
                        
diff --git a/cmake/fetch_cifar10.cmake b/cmake/fetch_cifar10.cmake
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 function(fetch_cifar10 DATA_DIR)
     set(CIFAR_DIR "${DATA_DIR}/cifar10")
diff --git a/cmake/fetch_datasets.cmake b/cmake/fetch_datasets.cmake
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 include(${CMAKE_CURRENT_LIST_DIR}/fetch_mnist.cmake)
 include(${CMAKE_CURRENT_LIST_DIR}/fetch_cifar10.cmake)
diff --git a/cmake/fetch_flickr8k.cmake b/cmake/fetch_flickr8k.cmake
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 function(fetch_flickr8k DATA_DIR)
     set(FLICKR8K_DIR "${DATA_DIR}/flickr_8k")
diff --git a/cmake/fetch_imagenette.cmake b/cmake/fetch_imagenette.cmake
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 function(fetch_imagenette DATA_DIR)
     set(IMAGENETTE_DIR "${DATA_DIR}/imagenette2-160")
diff --git a/cmake/fetch_libtorch.cmake b/cmake/fetch_libtorch.cmake
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 include(FetchContent)
 
diff --git a/cmake/fetch_mnist.cmake b/cmake/fetch_mnist.cmake
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 function(fetch_mnist DATA_DIR)
     set(MNIST_DOWNLOAD_DIR "${DATA_DIR}/mnist/download")
diff --git a/cmake/fetch_neural_style_transfer_images.cmake b/cmake/fetch_neural_style_transfer_images.cmake
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 function(fetch_neural_style_transfer_imagers DATA_DIR)
     set(NEURAL_STYLE_TRANSFER_IMAGES_DIR
diff --git a/cmake/fetch_penntreebank.cmake b/cmake/fetch_penntreebank.cmake
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 function(fetch_penntreebank DATA_DIR)
     set(PENNTREEBANK_DIR "${DATA_DIR}/penntreebank")
diff --git a/cmake/find_gz_extractor.cmake b/cmake/find_gz_extractor.cmake
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 # Find program that can extract .gz files.
 # Based on: https://github.com/Amber-MD/cmake-buildscripts/blob/master/gzip.cmake
diff --git a/extern/CMakeLists.txt b/extern/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(extern VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/notebooks/pytorch_cpp_colab_notebook.ipynb b/notebooks/pytorch_cpp_colab_notebook.ipynb
@@ -162,9 +162,9 @@
         "!rm -rf deps\n",
         "!mkdir deps\n",
         "%cd /content/deps\n",
-        "!wget --no-check-certificate https://www.cmake.org/files/v3.14/cmake-3.14.0-Linux-x86_64.tar.gz\n",
-        "!tar -xvf cmake-3.14.0-Linux-x86_64.tar.gz > /dev/null\n",
-        "%mv cmake-3.14.0-Linux-x86_64 cmake-install\n",
+        "!wget --no-check-certificate https://www.cmake.org/files/v3.19/cmake-3.19.0-Linux-x86_64.tar.gz\n",
+        "!tar -xvf cmake-3.19.0-Linux-x86_64.tar.gz > /dev/null\n",
+        "%mv cmake-3.19.0-Linux-x86_64 cmake-install\n",
         "old_path = %env PATH\n",
         "new_path = \"/content/deps/cmake-install:/content/deps/cmake-install/bin:\" + old_path\n",
         "%env PATH={new_path}\n",
diff --git a/tutorials/advanced/generative_adversarial_network/CMakeLists.txt b/tutorials/advanced/generative_adversarial_network/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(generative-adversarial-network VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/advanced/image_captioning/CMakeLists.txt b/tutorials/advanced/image_captioning/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(image-captioning VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/advanced/neural_style_transfer/CMakeLists.txt b/tutorials/advanced/neural_style_transfer/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(neural-style-transfer VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/advanced/variational_autoencoder/CMakeLists.txt b/tutorials/advanced/variational_autoencoder/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(variational-autoencoder VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/basics/feedforward_neural_network/CMakeLists.txt b/tutorials/basics/feedforward_neural_network/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(feedforward-neural-network VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/basics/linear_regression/CMakeLists.txt b/tutorials/basics/linear_regression/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(linear-regression VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/basics/logistic_regression/CMakeLists.txt b/tutorials/basics/logistic_regression/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(logistic-regression VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/basics/pytorch_basics/CMakeLists.txt b/tutorials/basics/pytorch_basics/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(pytorch-basics VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/intermediate/bidirectional_recurrent_neural_network/CMakeLists.txt b/tutorials/intermediate/bidirectional_recurrent_neural_network/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(bidirectional-recurrent-neural-network VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/intermediate/convolutional_neural_network/CMakeLists.txt b/tutorials/intermediate/convolutional_neural_network/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(convolutional-neural-network VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/intermediate/deep_residual_network/CMakeLists.txt b/tutorials/intermediate/deep_residual_network/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(deep-residual-network VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/intermediate/language_model/CMakeLists.txt b/tutorials/intermediate/language_model/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(language-model VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/intermediate/recurrent_neural_network/CMakeLists.txt b/tutorials/intermediate/recurrent_neural_network/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(recurrent-neural-network VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/popular/blitz/autograd/CMakeLists.txt b/tutorials/popular/blitz/autograd/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(autograd VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/popular/blitz/neural_networks/CMakeLists.txt b/tutorials/popular/blitz/neural_networks/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(neural-networks VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/popular/blitz/tensors/CMakeLists.txt b/tutorials/popular/blitz/tensors/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(tensors VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/tutorials/popular/blitz/training_a_classifier/CMakeLists.txt b/tutorials/popular/blitz/training_a_classifier/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(training-a-classifier VERSION 1.0.0 LANGUAGES CXX)
 
diff --git a/utils/image_io/CMakeLists.txt b/utils/image_io/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
 
 project(image-io VERSION 1.0.0 LANGUAGES CXX)
 

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ jobs:`
`26`	`26`	`- {`
`27`	`27`	`name: Windows MSVC 2019,`
`28`	`28`	`os: windows-2019,`
`29`		`- cmake: '3.14.0'`
	`29`	`+ cmake: '3.19.0'`
`30`	`30`	`}`
`31`	`31`	`- {`
`32`	`32`	`name: Windows MSVC 2022,`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-cmake_minimum_required(VERSION 3.14 FATAL_ERROR)`
	`1`	`+cmake_minimum_required(VERSION 3.19 FATAL_ERROR)`
`2`	`2`
`3`	`3`	`project(pytorch-cpp VERSION 1.0.0 LANGUAGES CXX)`
`4`	`4`