Skip to content

SMPP transport tear down should gracefully handle errors in set up. #1043

Description

@hodgestar

From praekeltfoundation/junebug#96:

When deleting an SMPP channel (in this instance it never successfully worked, but I don't know if that's relevant) the following error shows:

{
  "status": 500,
  "code": "Internal Server Error",
  "description": "generic error",
  "result": {
    "errors": [
      {
        "message": "'SmppTransceiverTransport' object has no attribute 'service'",
        "type": "AttributeError"
      }
    ]
  }
}

Likely this is caused by the SMPPService not being set up fully when it was started. See https://github.com/praekelt/vumi/blob/develop/vumi/transports/smpp/smpp_transport.py#L294 for where the error probably occurred.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions