Quiet clang warnings about non-static static members

pramsey · pramsey · commit 24ed18b9807a · 2025-05-20T10:06:38.000-07:00
diff --git a/ogr_fdw_info.c b/ogr_fdw_info.c
@@ -59,7 +59,7 @@ strip_spaces(char* str)
 /* in the ogr_fdw_common module works */
 const char* quote_identifier(const char* ident);
 
-char identifier[NAMEDATALEN+3];
+static char identifier[NAMEDATALEN+3];
 
 const char*
 quote_identifier(const char* ident)
@@ -76,7 +76,8 @@ quote_identifier(const char* ident)
 	}
   return identifier;
 }
-char config_options[STR_MAX_LEN] = {0};
+
+static char config_options[STR_MAX_LEN] = {0};
 
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ strip_spaces(char* str)`
`59`	`59`	`/* in the ogr_fdw_common module works */`
`60`	`60`	`const char* quote_identifier(const char* ident);`
`61`	`61`
`62`		`-char identifier[NAMEDATALEN+3];`
	`62`	`+static char identifier[NAMEDATALEN+3];`
`63`	`63`
`64`	`64`	`const char*`
`65`	`65`	`quote_identifier(const char* ident)`
`@@ -76,7 +76,8 @@ quote_identifier(const char* ident)`
`76`	`76`	`}`
`77`	`77`	`return identifier;`
`78`	`78`	`}`
`79`		`-char config_options[STR_MAX_LEN] = {0};`
	`79`	`+`
	`80`	`+static char config_options[STR_MAX_LEN] = {0};`
`80`	`81`
`81`	`82`
`82`	`83`	`static void`