Post install upgrade hooks job fails when using Istio

[thegooddalton]

Post install upgrade hooks job fails when using Istio

• When using Istio, the sidecar attaches to the post install upgrade job, the job completes however never finishes as the sidecar is attached.

[thegooddalton]

Suggested implementation;

Add a section to the Job spec template to allow for;

istio-injection=disabled

      {{- $ann := merge (default dict .Values.annotations) (default dict .Values.postInstallJobAnnotations) }}
      {{- if $ann }}
      annotations:
{{ toYaml $ann | indent 8 }}
      {{- end }}

apiVersion: batch/v1
kind: Job
metadata:
  name: {{ template "zookeeper-operator.fullname" . }}-post-install-upgrade
  namespace: {{ .Release.Namespace }}
  annotations:
    "helm.sh/hook": post-install, post-upgrade
    "helm.sh/hook-weight": "2"
    "helm.sh/hook-delete-policy": hook-succeeded, before-hook-creation, hook-failed
spec:
  backoffLimit: {{ .Values.hooks.backoffLimit }}
  template:
    metadata:
      name: {{ template "zookeeper-operator.fullname" . }}-post-install-upgrade
      {{- $ann := merge (default dict .Values.annotations) (default dict .Values.postInstallJobAnnotations) }}
      {{- if $ann }}
      annotations:
{{ toYaml $ann | indent 8 }}
      {{- end }}
    spec:
      serviceAccountName: {{ template "zookeeper-operator.fullname" . }}-post-install-upgrade
      restartPolicy: Never
      containers:
      - name: post-install-upgrade-job
        image: "{{ .Values.hooks.image.repository }}:{{ .Values.hooks.image.tag }}"
        {{- if .Values.hooks.securityContext }}
        securityContext:
{{ toYaml .Values.hooks.securityContext | indent 10 }}
        {{- end }}
        command:
          - /scripts/validations.sh
        volumeMounts:
          - name: sh
            mountPath: /scripts
            readOnly: true
      volumes:
        - name: sh
          configMap:
            name: {{ template "zookeeper-operator.fullname" . }}-post-install-upgrade
            defaultMode: 0555
      {{- if .Values.nodeSelector }}
      nodeSelector:
{{ toYaml .Values.nodeSelector | indent 8 }}
      {{- end }}
      {{- if .Values.affinity }}
      affinity:
{{ toYaml .Values.affinity | indent 8 }}
      {{- end }}
      {{- if .Values.tolerations }}
      tolerations:
{{ toYaml .Values.tolerations | indent 8 }}
      {{- end }}