Skip to content

Commit 50e4b25

Browse files
committed
test: fix deep equal ...again
1 parent e528d60 commit 50e4b25

1 file changed

Lines changed: 8 additions & 26 deletions

File tree

parser_test.go

Lines changed: 8 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,6 @@ type (
5656

5757
float32Alias float32
5858
float64Alias float64
59-
60-
timeAlias time.Time
6159
)
6260

6361
func TestStrings(t *testing.T) {
@@ -466,36 +464,23 @@ func TestFloats(t *testing.T) {
466464

467465
func TestTime(t *testing.T) {
468466
type times struct {
469-
F1 time.Time `qp:"f1"`
470-
F2 *time.Time `qp:"f2"`
471-
F3 timeAlias `qp:"f3"`
472-
F4 *timeAlias `qp:"f4"`
473-
F5 time.Time `qp:"-"`
474-
F6 []time.Time `qp:"f6"`
467+
F1 time.Time `qp:"f1"`
468+
F2 *time.Time `qp:"f2"`
469+
F3 time.Time `qp:"-"`
475470
}
476471

477472
currDate := time.Now().Truncate(time.Nanosecond)
478473

479474
dateStr := currDate.Format(time.RFC3339Nano)
480475
queryParams := fmt.Sprintf(
481-
"f1=%s&f2=%s&f3=%s&f4=%s&f5=ignored&f6=%s,%s",
482-
dateStr,
483-
dateStr,
484-
dateStr,
485-
dateStr,
476+
"f1=%s&f2=%s&f3=ignored",
486477
dateStr,
487478
dateStr,
488479
)
489480
expected := times{
490481
F1: currDate,
491482
F2: ptr(currDate),
492-
F3: timeAlias(currDate),
493-
F4: ptr(timeAlias(currDate)),
494-
F5: time.Time{},
495-
F6: []time.Time{
496-
currDate,
497-
currDate,
498-
},
483+
F3: time.Time{},
499484
}
500485

501486
values, err := url.ParseQuery(queryParams)
@@ -505,12 +490,9 @@ func TestTime(t *testing.T) {
505490
err = parse(values, &result)
506491

507492
require.Nil(t, err)
508-
require.Equal(t, expected.F1, result.F1)
509-
require.Equal(t, expected.F2, result.F2)
510-
require.Equal(t, expected.F3, result.F3)
511-
require.Equal(t, expected.F4, result.F4)
512-
require.Equal(t, expected.F5, result.F5)
513-
require.Equal(t, expected.F6, result.F6)
493+
require.True(t, expected.F1.Equal(result.F1))
494+
require.True(t, expected.F2.Equal(*result.F2))
495+
require.True(t, expected.F3.Equal(result.F3))
514496

515497
t.Run("Invalid", func(t *testing.T) {
516498
queryParams := "f1=invalid-date"

0 commit comments

Comments
 (0)