Rename challenge kind to special, matching forum rules terminology

The forum rules use three tiers: core (streak + category leaderboard),
special (streak-eligible workouts, no category leaderboard), and bonus
(not streak-eligible). Rename challenge → special to match.

Four kinds: core, special, bonus, penalty.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: prazgaitis

apps/web/components/admin/admin-activity-types-table.tsx

@@ -159,7 +159,7 @@ export function AdminActivityTypesTable({
         isNegative: createNegative,
         availableInFinalDays: createAvailableInFinalDays || undefined,
         categoryId: createCategoryId ? (createCategoryId as Id<"categories">) : undefined,
-        kind: (createKind || undefined) as "core" | "challenge" | "bonus" | "penalty" | undefined,
+        kind: (createKind || undefined) as "core" | "special" | "bonus" | "penalty" | undefined,
         displayOrder: Number.isFinite(parsedDisplayOrder) && createDisplayOrder !== "" ? parsedDisplayOrder : undefined,
       });
       setCreateName("");
@@ -256,7 +256,7 @@ export function AdminActivityTypesTable({
         availableInFinalDays: editAvailableInFinalDays || undefined,
         bonusThresholds: editThresholds,
         categoryId: editCategoryId ? (editCategoryId as Id<"categories">) : undefined,
-        kind: (editKind || undefined) as "core" | "challenge" | "bonus" | "penalty" | undefined,
+        kind: (editKind || undefined) as "core" | "special" | "bonus" | "penalty" | undefined,
         displayOrder: Number.isFinite(parsedDisplayOrder) && editDisplayOrder !== "" ? parsedDisplayOrder : undefined,
       });
       setEditingId(null);
@@ -422,7 +422,7 @@ export function AdminActivityTypesTable({
               >
                 <option value="">—</option>
                 <option value="core">Core</option>
-                <option value="challenge">Challenge</option>
+                <option value="special">Special</option>
                 <option value="bonus">Bonus</option>
                 <option value="penalty">Penalty</option>
               </select>
@@ -654,7 +654,7 @@ export function AdminActivityTypesTable({
                                 >
                                   <option value="">—</option>
                                   <option value="core">Core</option>
-                                  <option value="challenge">Challenge</option>
+                                  <option value="special">Special</option>
                                   <option value="bonus">Bonus</option>
                                   <option value="penalty">Penalty</option>
                                                   </select>

apps/web/tests/api/activity-type-kind.test.ts

@@ -64,7 +64,7 @@ describe("Activity type kind field", () => {
   it("updateActivityType updates kind", async () => {
     const id = await createTestActivityType(t, challengeId, {
       name: "Bonus",
-      kind: "challenge",
+      kind: "special",
     });
 
     await tWithAuth.mutation(api.mutations.activityTypes.updateActivityType, {
@@ -227,7 +227,7 @@ describe("Activity type kind field", () => {
       }
     });
 
-    it("classifies challenge activities (completion, tiered, non-standard units)", async () => {
+    it("classifies special activities (completion, tiered, non-standard units)", async () => {
       await createTestActivityType(t, challengeId, {
         name: "Hotel Room Workout",
         scoringConfig: { type: "completion", fixedPoints: 50 },
@@ -258,11 +258,11 @@ describe("Activity type kind field", () => {
       );
 
       for (const r of result.results) {
-        expect(r.kind).toBe("challenge");
+        expect(r.kind).toBe("special");
       }
     });
 
-    it("classifies unit_based with maxPerChallenge as challenge, not core", async () => {
+    it("classifies unit_based with maxPerChallenge as special, not core", async () => {
       await createTestActivityType(t, challengeId, {
         name: "The Max",
         scoringConfig: { type: "unit_based", pointsPerUnit: 25, unit: "circuits", maxUnits: 3 },
@@ -276,7 +276,7 @@ describe("Activity type kind field", () => {
         { challengeId },
       );
 
-      expect(result.results[0]).toMatchObject({ name: "The Max", kind: "challenge" });
+      expect(result.results[0]).toMatchObject({ name: "The Max", kind: "special" });
     });
 
     it("skips rows that already have kind set", async () => {
@@ -364,7 +364,7 @@ describe("Activity type kind field", () => {
         Swimming: "core",
         "The Hunt Bonus": "bonus",
         Overindulge: "penalty",
-        "The Murph": "challenge",
+        "The Murph": "special",
       });
     });
   });

packages/backend/mutations/activityTypes.ts

@@ -15,7 +15,7 @@ const bonusThresholdsArg = v.optional(
 const kindArg = v.optional(
   v.union(
     v.literal("core"),
-    v.literal("challenge"),
+    v.literal("special"),
     v.literal("bonus"),
     v.literal("penalty"),
   )
@@ -251,7 +251,7 @@ export const backfillKind = mutation({
       }
 
       const nameLower = at.name.toLowerCase();
-      let kind: "core" | "challenge" | "bonus" | "penalty";
+      let kind: "core" | "special" | "bonus" | "penalty";
 
       if (at.isNegative) {
         kind = "penalty";
@@ -277,8 +277,8 @@ export const backfillKind = mutation({
         // Repeatable distance/duration activities = core fitness
         kind = "core";
       } else {
-        // Everything else: completion workouts, tiered challenges, etc.
-        kind = "challenge";
+        // Everything else: special workouts (completion, tiered, non-standard units)
+        kind = "special";
       }
 
       if (!args.dryRun) {

packages/backend/mutations/apiMutations.ts

@@ -846,7 +846,7 @@ export const createActivityTypeForUser = internalMutation({
     kind: v.optional(
       v.union(
         v.literal("core"),
-        v.literal("challenge"),
+        v.literal("special"),
         v.literal("bonus"),
         v.literal("penalty"),
       )
@@ -893,7 +893,7 @@ export const updateActivityTypeForUser = internalMutation({
     kind: v.optional(
       v.union(
         v.literal("core"),
-        v.literal("challenge"),
+        v.literal("special"),
         v.literal("bonus"),
         v.literal("penalty"),
       )

packages/backend/schema.ts

@@ -73,12 +73,12 @@ export default defineSchema({
     isNegative: v.boolean(),
     categoryId: v.optional(v.id("categories")),
     // Semantic classification orthogonal to categoryId (which drives Category Leader leaderboard).
-    // core = standard fitness activities, challenge = special workouts,
-    // bonus = system-awarded or non-competitive bonuses, penalty = negative-scoring
+    // core = standard fitness activities, special = special workouts (streak-eligible, not in category leaderboard),
+    // bonus = system-awarded or non-competitive bonuses (not streak-eligible), penalty = negative-scoring
     kind: v.optional(
       v.union(
         v.literal("core"),
-        v.literal("challenge"),
+        v.literal("special"),
         v.literal("bonus"),
         v.literal("penalty"),
       ),
@@ -383,7 +383,7 @@ export default defineSchema({
     kind: v.optional(
       v.union(
         v.literal("core"),
-        v.literal("challenge"),
+        v.literal("special"),
         v.literal("bonus"),
         v.literal("penalty"),
       ),