From 09204d8d14cc1b6ac8a2c9c55120251704785adb Mon Sep 17 00:00:00 2001 From: Jacob Ebey Date: Thu, 13 Jun 2024 00:25:27 -0700 Subject: [PATCH 1/2] fix: hydration might remove the node from the DOM causing it no longer have a parent --- src/lib/client.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/client.js b/src/lib/client.js index c0f5cb7..b232562 100644 --- a/src/lib/client.js +++ b/src/lib/client.js @@ -36,7 +36,7 @@ // c = s; // } -// d.parentNode.removeChild(d); +// if (d.parentNode) d.parentNode.removeChild(d); // }); // } // } @@ -46,7 +46,7 @@ // } // To modify the INIT_SCRIPT, uncomment the above code, modify it, and paste it into https://try.terser.org/. -const INIT_SCRIPT = `class e extends HTMLElement{connectedCallback(){var e=this;if(!e.isConnected)return;let t=this.getAttribute("data-target");if(t){for(var r,a,i=document.createNodeIterator(document,128);i.nextNode();){let e=i.referenceNode;if(e.data=="preact-island:"+t?r=e:e.data=="/preact-island:"+t&&(a=e),r&&a)break}r&&a&&requestAnimationFrame((()=>{for(var t=a.previousSibling;t!=r&&t&&t!=r;)a.parentNode.removeChild(t),t=a.previousSibling;for(i=r;e.firstChild;)r=e.firstChild,e.removeChild(r),i.after(r),i=r;e.parentNode.removeChild(e)}))}}}customElements.define("preact-island",e);`; +const INIT_SCRIPT = `class e extends HTMLElement{connectedCallback(){var e=this;if(!e.isConnected)return;let t=this.getAttribute("data-target");if(t){for(var r,a,i=document.createNodeIterator(document,128);i.nextNode();){let e=i.referenceNode;if(e.data=="preact-island:"+t?r=e:e.data=="/preact-island:"+t&&(a=e),r&&a)break}r&&a&&requestAnimationFrame((()=>{for(var t=a.previousSibling;t!=r&&t&&t!=r;)a.parentNode.removeChild(t),t=a.previousSibling;for(i=r;e.firstChild;)r=e.firstChild,e.removeChild(r),i.after(r),i=r;e.parentNode&&e.parentNode.removeChild(e)}))}}}customElements.define("preact-island",e);`; export function createInitScript() { return ``; From af0e7dfe54bfcd0860808faeb6265a9a63ed1b64 Mon Sep 17 00:00:00 2001 From: Jacob Ebey Date: Thu, 13 Jun 2024 00:26:09 -0700 Subject: [PATCH 2/2] Create eighty-tools-search.md --- .changeset/eighty-tools-search.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/eighty-tools-search.md diff --git a/.changeset/eighty-tools-search.md b/.changeset/eighty-tools-search.md new file mode 100644 index 0000000..7bc3abb --- /dev/null +++ b/.changeset/eighty-tools-search.md @@ -0,0 +1,5 @@ +--- +"preact-render-to-string": patch +--- + +fix: hydration might remove the node from the DOM causing it no longer have a parent